feat: silent give command

Slimefun / Slimefun4

Slimefun 4 - A unique Spigot/Paper plugin that looks and feels like a modpack. We've been giving you backpacks, jetpacks, reactors and much more since 2013.

GNU General Public License v3.0

964 stars 547 forks source link

feat: silent give command #4196

Closed ybw0014 closed 4 weeks ago

ybw0014 commented 4 months ago

Description

Adds a silent_give command to give items to players without notifying them.

Proposed changes

Move the logics to AbstractGiveCommand, and pass arguments to determine whether the receiver should get a notification.

Related Issues (if applicable)

Discord suggestion 2579

Checklist

[x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
[ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
[ ] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16. - 1.20.).
[x] I followed the existing code standards and didn't mess up the formatting.
[x] I did my best to add documentation to any public classes or methods I added.
[ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
[ ] I added sufficient Unit Tests to cover my code.

github-actions[bot] commented 4 months ago

Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️ Branch naming convention	Label
`feature/**`	🎈 Feature
`fix/**`	✨ Fix
`chore/**`	🧹 Chores
`api/**`	🔧 API
`performance/**`	💡 Performance Optimization
`compatibility/**`	🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

github-actions[bot] commented 4 months ago

Slimefun preview build

A Slimefun preview build is available for testing! Commit: a1bd9c8a

https://preview-builds.walshy.dev/download/Slimefun/4196/a1bd9c8a

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

JustAHuman-xD commented 4 months ago

Is there a reason for the class being abstract here? if all you are changing is the constructer arguments then the class doesn't need to be abstract, just have a give command that's created twice with the corresponding silent and not silent arguments. unless I'm missing something anyways

ybw0014 commented 4 months ago

Is there a reason for the class being abstract here? if all you are changing is the constructer arguments then the class doesn't need to be abstract, just have a give command that's created twice with the corresponding silent and not silent arguments. unless I'm missing something anyways

to keep the SlimefunSubCommands format consistent.

JustAHuman-xD commented 4 months ago

to keep the SlimefunSubCommands format consistent.

Hmmmm, like fair but also aaaaaa

ybw0014 commented 4 months ago

Hmmmm, like fair but also aaaaaa

I would like to see others' opinions.