Slimefun / Slimefun4

Slimefun 4 - A unique Spigot/Paper plugin that looks and feels like a modpack. We've been giving you backpacks, jetpacks, reactors and much more since 2013.
GNU General Public License v3.0
943 stars 535 forks source link

Slimefun Build 1145 produces errors on Paper 1.20.6 (build #124) #4199

Open CodingWithAnxiety opened 1 month ago

CodingWithAnxiety commented 1 month ago

โ— Checklist

๐Ÿ“ Description

When starting a 1.20.6 server using paper, whilst having the latest Slimefun dev version installed, the following error occurs:

[00:36:41 ERROR]: [dough: skins] Failed to detect skull nbt methods
java.lang.NoSuchMethodException: net.minecraft.world.level.block.entity.SkullBlockEntity.a(com.mojang.authlib.GameProfile)
    at java.base/java.lang.Class.getMethod(Class.java:2395) ~[?:?]
    at io.papermc.reflectionrewriter.runtime.AbstractDefaultRulesReflectionProxy.getMethod(AbstractDefaultRulesReflectionProxy.java:100) ~[reflection-rewriter-runtime-0.0.1.jar:?]
    at io.papermc.paper.pluginremap.reflect.PaperReflectionHolder.getMethod(Unknown Source) ~[paper-1.20.6.jar:1.20.6-124-0fcf3e3]
    at Slimefun4-Dev(1).jar/io.github.thebusybiscuit.slimefun4.libraries.dough.skins.nms.PlayerHeadAdapter18.<init>(PlayerHeadAdapter18.java:23) ~[Slimefun4-Dev(1).jar:?]
    at Slimefun4-Dev(1).jar/io.github.thebusybiscuit.slimefun4.libraries.dough.skins.nms.PlayerHeadAdapter.get(PlayerHeadAdapter.java:31) ~[Slimefun4-Dev(1).jar:?]
    at Slimefun4-Dev(1).jar/io.github.thebusybiscuit.slimefun4.libraries.dough.skins.PlayerHead.<clinit>(PlayerHead.java:23) ~[Slimefun4-Dev(1).jar:?]
    at Slimefun4-Dev(1).jar/io.github.thebusybiscuit.slimefun4.utils.SlimefunUtils.getCustomHead(SlimefunUtils.java:246) ~[Slimefun4-Dev(1).jar:?]
    at Slimefun4-Dev(1).jar/io.github.thebusybiscuit.slimefun4.core.services.localization.Language.<init>(Language.java:52) ~[Slimefun4-Dev(1).jar:?]
    at Slimefun4-Dev(1).jar/io.github.thebusybiscuit.slimefun4.core.services.LocalizationService.<init>(LocalizationService.java:67) ~[Slimefun4-Dev(1).jar:?]
    at Slimefun4-Dev(1).jar/io.github.thebusybiscuit.slimefun4.implementation.Slimefun.onPluginStart(Slimefun.java:300) ~[Slimefun4-Dev(1).jar:?]
    at Slimefun4-Dev(1).jar/io.github.thebusybiscuit.slimefun4.implementation.Slimefun.onEnable(Slimefun.java:241) ~[Slimefun4-Dev(1).jar:?]
    at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:287) ~[paper-api-1.20.6-R0.1-SNAPSHOT.jar:?]
    at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[paper-1.20.6.jar:1.20.6-124-0fcf3e3]
    at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[paper-1.20.6.jar:1.20.6-124-0fcf3e3]
    at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:519) ~[paper-api-1.20.6-R0.1-SNAPSHOT.jar:?]
    at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:604) ~[paper-1.20.6.jar:1.20.6-124-0fcf3e3]
    at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:553) ~[paper-1.20.6.jar:1.20.6-124-0fcf3e3]
    at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:675) ~[paper-1.20.6.jar:1.20.6-124-0fcf3e3]
    at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:437) ~[paper-1.20.6.jar:1.20.6-124-0fcf3e3]
    at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:323) ~[paper-1.20.6.jar:1.20.6-124-0fcf3e3]
    at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1136) ~[paper-1.20.6.jar:1.20.6-124-0fcf3e3]
    at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:323) ~[paper-1.20.6.jar:1.20.6-124-0fcf3e3]
    at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

In addition, having the Exotic Garden plugin installed furthers the issue. As exotic garden is a community plugin, I will not discuss it any further beyond the following pastebin link; https://paste.ee/p/RiOjp

๐Ÿ“‘ Reproduction Steps

  1. Prepare a base, 1.20.6, paper server.
    • No configuration needs to be made to the server, minus eula=true
  2. Launch the server. I am doing this using OpenJDK 21
  3. Presented with error.

๐Ÿ’ก Expected Behavior

No errors to occur during startup of the server.

๐Ÿ“ท Screenshots / Videos

image

https://github.com/Slimefun/Slimefun4/assets/78890450/47306bee-3dd8-42b5-832c-b3ee7ba6b793

I do not scroll within the video.

๐Ÿ“œ Server Log

https://paste.ee/p/9RBoV

๐Ÿ“‚ /error-reports/ folder

N/A

๐Ÿ’ป Server Software

Paper

๐ŸŽฎ Minecraft Version

1.20.x

โญ Slimefun version

slimefun versions [00:52:07 INFO]: This Server uses the following setup of Slimefun: Paper 1.20.6-124-0fcf3e3 (MC: 1.20.6) Slimefun Dev - 1145 Java 21

Installed Addons: (1) ExoticGarden vDEV - 78 (git 7f9a5f63)

๐Ÿงญ Other plugins

This error exists within both ExoticGarden alongside slimefun. I recall seeing outputted errors from EcoPower, however I did not have it installed in none of my logs which are linked here.

CodingWithAnxiety commented 1 month ago

Renamed. The server still works (assuming Exotic Garden isn't installed) however the errors still cocur.

CodingWithAnxiety commented 1 month ago

From the discord bugs channel:

Errors in the slimefun plugins folder are not documented as it does not produce any errors within this folder.

JustAHuman-xD commented 1 month ago

We donโ€™t support 1.20.5+

JustAHuman-xD commented 1 month ago

Update is a WIP

CodingWithAnxiety commented 1 month ago

Got-cha. Well, I hope this report helps you trace down another bug.

EpicPlayerA10 commented 1 month ago

The error lies in dough lib. Here is a PR that adds support for 1.20.6 https://github.com/Slimefun/dough/pull/271

CodingWithAnxiety commented 1 month ago

I thought it had something to do with dough considering the errors were being spat with dough's name in them. Good catch.