Feature/amethyst farm - Githubissues

Intybyte commented 1 month ago

Description

An amethyst virtual farm, that would work like the others virtual farms, could be useful considering some players play on worlds where the nearest Amethyst Geode can be really far as their world started in earlier versions.

Proposed changes

Create an abastract class dedicated to generating item using energy only, the recipes will require 1 input and 1 output max and clicking on the input slot will toggle the item generated.

CrystalGrower which will grow amethyst will be the first block to use such class.

TODO

Decide recipe Decide power settings (capacity, speed, consumption)

Approved suggestion

Discord approved suggestion number #1592

Checklist

[x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
[ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
[ ] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16. - 1.20.).
[x] I followed the existing code standards and didn't mess up the formatting.
[ ] I did my best to add documentation to any public classes or methods I added.
[x] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
[ ] I added sufficient Unit Tests to cover my code.

github-actions[bot] commented 1 month ago

Your Pull Request was automatically labelled as: "🎈 Feature" Thank you for contributing to this project! ❤️

github-actions[bot] commented 1 month ago

Slimefun preview build

A Slimefun preview build is available for testing! Commit: cfdde20a

https://preview-builds.walshy.dev/download/Slimefun/4232/cfdde20a

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

Boomer-1 commented 1 month ago

for what it's worth, there's currently 3 or 4 addons that provide ways to get amethyst. not against it, but want to weigh that in

Sfiguz7 commented 1 month ago

I have yet to look at it but if it's thought of as a virtual farm shouldn't it go in infinity with the other virtual farms?

Intybyte commented 1 month ago

I have yet to look at it but if it's thought of as a virtual farm shouldn't it go in infinity with the other virtual farms?

I have no idea if that was the intention of the creator of the suggestion, tbh i just fish ideas that i would like to code and make PR about them and if they are merged good, if they are not i had fun while doing it, the whole suggestion channel imo should be divided into a #suggesitons and #addon-suggestions

TheBusyBiscuit commented 1 month ago

I have yet to look at it but if it's thought of as a virtual farm shouldn't it go in infinity with the other virtual farms?

I have no idea if that was the intention of the creator of the suggestion, tbh i just fish ideas that i would like to code and make PR about them and if they are merged good, if they are not i had fun while doing it, the whole suggestion channel imo should be divided into a #suggesitons and #addon-suggestions

It is a good point, we tried to heavily enforce things like "only suggest ideas for slimefun, not addons" in the past but it did not work out. Seperating channels is also something we have had not much luck with. In general in many players' minds there is no real seperation between Slimefun and addons as there is from a developer's perspective. But I absolutely get your point! Glad you had fun doing it and hope to see you in a future PR o/

Slimefun / Slimefun4

Feature/amethyst farm #4232