In GitHubTask we're doing Optional<String> skin = Optional.of(future.get().toString()); where future.get() returns PlayerSkin. However, PlayerSkin does not have a toString() function and therefore this was resulting in the normal Object#toString meaning skin was like io.github.thebusybiscuit.slimefun4.libraries.dough.skins.PlayerSkin@abcdef123 instead of the base64 texture.
Allows fixing https://github.com/Slimefun/Slimefun4/issues/4071
In
GitHubTaskwe're doingOptional<String> skin = Optional.of(future.get().toString());wherefuture.get()returnsPlayerSkin. However,PlayerSkindoes not have atoString()function and therefore this was resulting in the normal Object#toString meaningskinwas likeio.github.thebusybiscuit.slimefun4.libraries.dough.skins.PlayerSkin@abcdef123instead of the base64 texture.This update allows us to get the CustomGameProfile from the PlayerSkin (function made available here: https://github.com/baked-libs/dough/commit/08722d5b889632fbc5d22f31508a2fec424dc112) and we can now do
getBase64Textureto grab the needed texture.Slimefun PR pending dough merge: https://github.com/Slimefun/Slimefun4/pull/4072