Closed ktzhu closed 11 years ago
I think we could just check if all categories have a value of 0 for time (meaning no data has been recorded) and then return a different graphic/text, but yeah, good point.
Ok, it's time to pay attention to new user experience a bit. Here's what I saw when I tried it...
prescription tab - I put in a message for when there is no data stored, but perhaps having no data is causing other bugs, so I'll work on that.
@bhuang92 I see this happening on a new install with no data (as of 15eb64ed3d):
In here, users should not be meeting 33% of all their goals. I think the diversity thing is wrong.
So the 33.3% is percent of goals reached for ALL categories; not just the category selected. Does that clear anything up?
Or is this for like the new user? I guess I should handle that differently
@bhuang92 @ktzhu I've done a bunch of refactoring in 15eb64ed3d.
isNewUser()
, which checks total reading time and compares against a new threshold value called secondsBeforeActive
for minimum time required to not be a new user (defined in 'app/config.coffee' as 1 second), and returns a boolean response.@bhuang92 Yeah, this screenshot was taken as a new user, and for a new user it should be 0%, I believe
Gotcha. Okay, yeah right now it just checks to see if nothing is above the "bias proportion of time," and if that's the case, then it'll return that it's diverse. I guess it should be above bias proportion of time and time is not 0. If time is 0, then display diversity not met yet also.
Hey, I fixed the diversity part. It now says there's not enough data when the user has totalTime = 0 for a specific category. The diversity part of overall health is then not satisfied either. (i still dont know how to insert images.. but here http://i.imgur.com/gcrwdiS.png)
pretty much fixed across the board by de6ce0c838