Slimmmo / Slimmmo.github.io

AdVenture Capitalist calculator
http://slimmmo.github.io/
35 stars 42 forks source link

Save (some) filters #19

Closed 61352151511 closed 8 years ago

61352151511 commented 8 years ago

I don't know if this is backwards compatible. If you know it will break loading suggest a way for me to fix it and I will add that in. I have a feeling if noSingles and noTens isn't saved it won't load properly but I am unsure. I attempted to save the time filters however couldn't get it to work correctly so perhaps you could add that in at some point. This at least keeps the Don't show +1 and Don't show +10 upon reloading.

Slimmmo commented 8 years ago

It will break backwards compatibility. However this should work fine I think '$scope[loadArr[k]].noSingles = obj[loadArr[k]].noSingles || false;'. So if you update it to that I'll merge.

You could probably also apply the same || trick to the time filters and get it working if you want. Let me know.

61352151511 commented 8 years ago

Fixed that, the issue I was having with the time filters was that they don't seem to be like the noSingles or noTens. Each planet has it's own individual noSingles/noTens variable yet I found when I was trying to get the time saved/loaded it acted as if there was only one variable for it. All the planets ended up loading the same time filter instead of individual ones. Perhaps if I have more time at some point I can fidget around with it some more and see if I can get that to work.