Possible fix for issues #17 and #57 (decimal places for percentage filter and ignore +100 option

Slimmmo / Slimmmo.github.io

AdVenture Capitalist calculator

http://slimmmo.github.io/

35 stars 42 forks source link

Possible fix for issues #17 and #57 (decimal places for percentage filter and ignore +100 option #69

Closed ricardopetrere closed 8 years ago

ricardopetrere commented 8 years ago

The last comment at issue #17 and issue #57 suggest two features:

The possibility to hide +100 from the Recommendations table (showing just unlocks and upgrades)
The possibility to specify a decimal value at the percentage filter (e. g. 3.8%), instead of just integers

Please see if this would suffice both :)

Slimmmo commented 8 years ago

Quick question, why is it a text field instead of a number field with a step of 0.1?

ricardopetrere commented 8 years ago

I also asked that question myself (it was already this way hahaha)

I think it's this way so that it doesn't show those up/down arrows, like the x3 multipliers does (at least, when I changed "type" to number, it did that). To be more "UI pleasant", perhaps.

Besides, if it were a number field, there wouldn't be the need of those blue arrows controls, so it was made on purpose.

Slimmmo commented 8 years ago

Ah yeah that's right. I couldn't figure out how to hide the up/down arrows on all the browsers. Merging.