Slion / Fulguris

⚡Web Browser
http://fulguris.slions.net
Other
457 stars 48 forks source link

Content Control not performing as expected #293

Open Slion opened 2 years ago

Slion commented 2 years ago

A user posted the following review:

Tried the full version from your site slions, but this browser has a huge flaw, adblocker isn't much powerful, some ads find their way in pages as this one is based on lightning & yuzu. Yuzu & its forks(like berry) have this issue also. Try to eliminate this shortcoming. With same filter lists Via is blocking everything strictly. Hope this will become better in future versions. Good luck dev!

Then sent us the following email:

Basically the 'Annoyances' lists isn't working properly the way it should. I'm attaching a .txt file with this email. This .txt file basically contains the remote filter list links that I use for ad-blocking. And there is one more thing Fulguris doesn't support the 'uAssets' filters like unbreak & resource abuse, why?
& the site I tested last is
a2zapk(dot)com
I can't remember other sites than this right now.
I omitted some filters that Fulguris refused to update. Adguard filters mostly.

Here is the content of the text file he mentioned:

Adblock filter lists

https://filters.adtidy.org/extension/ublock/filters/2_without_easylist.txt

https://filters.adtidy.org/extension/ublock/filters/11.txt    ~ Adguard Mobile Filters

https://easylist.to/easylist/easyprivacy.txt

https://easylist-downloads.adblockplus.org/antiadblockfilters.txt

https://raw.githubusercontent.com/reek/anti-adblock-killer/master/anti-adblock-killer-filters.txt

https://curben.gitlab.io/malware-filter/urlhaus-filter-online.txt

https://secure.fanboy.co.nz/fanboy-annoyance.txt

https://raw.githubusercontent.com/bogachenko/fuckfuckadblock/master/fuckfuckadblock.txt

https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/resource-abuse.txt

https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/unbreak.txt

https://easylist-msie.adblockplus.org/abp-filters-anti-cv.txt
Helium314 commented 2 years ago

Annoyances list shoud work like any other list. It consists mostly of element hiding rules, and is not implemented because I couldn't get it working. From the comment I suspect it actually isn't working in Yuzu, which explains why I couldn't get it working by trying to clone Yuzu behauvior more strictly.

Some parts of it are implemented in the current blocker though, so if anyone is interested, go for it. I don't plan on improving this anytime soon, as I don't have too much time. My main reason for implementing the blocker was privacy, and element hiding has no effect here.

Fulguris doesn't support the 'uAssets' filters like unbreak & resource abuse, why?

Because uAssets is using uBlock Origin syntax, which is in some parts different from the more universal AdBlockPlus syntax. E.g. instead of $third-party, uAssets list uses $3p. And it has some additional rules like $badfilter. uBO compatibilty is adressed in #242, but there are some rules where I need better understanding to implement them (which is the initial reason this PR got a bit stuck)

Cwpute commented 1 month ago

Encountered another website affected by this issue today: www.hohner.com Can't open the burger menu as it makes the page unresponsive (Fulguris is still responding).

Any progress on the matter ? it'd be much, much appreciated, as i still encounter this bug every day or so.

Helium314 commented 1 month ago

I haven't done anything on content control in a long time. Possibly giving a "not available" response for blocked resources gives different (better?) results than the current approach of using a dummy resoponst containing empty html/image/script/...