Slion / Fulguris

⚡Web Browser
http://fulguris.slions.net
Other
498 stars 49 forks source link

More theme options #408

Open NektoNektovich opened 2 years ago

NektoNektovich commented 2 years ago

fulguris has two identical very black themes for what? My eyes hurt from both snow-white and black! 😣 please make the dark theme exactly like the original lightning browser, and please add a setting for the light theme of sites with a dark theme of the browser interface 🤓

Slion commented 2 years ago

fulguris has two identical very black themes for what?

That is indeed questionable and is mostly historical I guess. One is black, those were designed for OLED screen to save power by turning off as many pixels as possible. One is dark, more aligned with the dark themes you find today I guess.

please make the dark theme exactly like the original lightning browser

I'm not sure what that looked like TBH. Though I'm guessing that's close from the early Android dark theme and those were just kinda darg gray if I recall well.

please add a setting for the light theme of sites with a dark theme of the browser interface 🤓

Good point, not sure that's doable.

My eyes hurt from both snow-white and black

Sorry to hear that, is the dark theme still too dark for you?

NektoNektovich commented 2 years ago

fulguris has two identical very black themes for what?

That is indeed questionable and is mostly historical I guess. One is black, those were designed for OLED screen to save power by turning off as many pixels as possible. One is dark, more aligned with the dark themes you find today I guess.

please make the dark theme exactly like the original lightning browser

I'm not sure what that looked like TBH. Though I'm guessing that's close from the early Android dark theme and those were just kinda darg gray if I recall well.

please add a setting for the light theme of sites with a dark theme of the browser interface 🤓

Good point, not sure that's doable.

My eyes hurt from both snow-white and black

Sorry to hear that, is the dark theme still too dark for you?

I use the fulguris dark theme, not the black amoled one, but I don’t see any serious differences between them, they are both too dark. Nearby I use a browser in 1dm 15.2, which is also based on lightning browser, there is a dark theme that is original and very pleasing to the eyes, there is also a setting for a light theme for sites with a dark browser interface, as well as an original algorithm for hiding the address bar without sticking when scrolling, and you in a vertical orientation, the address bar sticks in a hidden state with any setting, of which there are many, but they work the same, which is inconvenient for me, I can’t set it up for myself🙁 I also wanted to ask for the integration of third-party download managers, like mobile firefox, vivaldi, pure browser, via browser, but I'm glad that although there is a built-in one, the download destination folder of which can be transferred to the memory card along the path Android / data.

luckkmaxx commented 1 year ago

Regarding themes, maybe it could be according with new Monet android themes. EDIT: I've just to open #426 Apart of this, regarding people who hurts they eyes on some colors, there is an open source color scheme named Solarized (dark and light), wich helps exactly on this kind of problem.

The-First-King commented 7 months ago

In the Lightning web-browser, the black (for AMOLED) theme worked great. It has been applicable to the web-browser's interface only and not to websites. In Fulguris, when selecting this theme, it impacts website's coloring also. For example, www.samba.org turns into a dark mode. Is it possible to use AMOLED black theme without changing the default color of websites?

Slion commented 7 months ago

I think it is feature of the website itself. It might be possible the override it but I don't really see the point of having dark UI and light websites.

The-First-King commented 7 months ago

The reason is to have UI customization because not all likes snow-white, dark, or black UIs in applications.

The author of this issue has mentioned that in the Lightning web-browser it worked. I can recall also that it worked there. I still have an old device with Lightning installed and can provide a screenshot to confirm that if needed.

By default, in the beginning of WWW era, all backgrounds at websites were white. Later, the CSS design appeared. In our days, websites can check the browser’s theme and suggest the same them to display for the website content. Not all old dudes who still remember dinosaurs like this approach.

In the desktop version of Firefox, the same thing can be easily achieved by changing the 'layout.css.prefers-color-scheme.content-override' to 1 in about:config.

Slion commented 7 months ago

Yes it's very likely that since Lightning is still using an older version of WebKit and Android SDK and theme it would not support web site theming. Therefore web sites will just provide their default theme which is usually the light one. It's not a feature, it's a bug 😁

The correct and expected behaviour is for web sites to use the theme currently used by the application which is what Fulguris does at the moment.

There might be ways to select the web site colour scheme independently from the UI colour scheme, we could even possibly make this a domain preference. Though I'm not sure which is the best approach for that.

See docs.