Custom user agent adaditional checks / Intent-Activity refactor ...

Slion / Fulguris

⚡Web Browser

http://fulguris.slions.net

Other

455 stars 48 forks source link

Custom user agent adaditional checks / Intent-Activity refactor ... #610

Closed ZhymabekRoman closed 3 months ago

ZhymabekRoman commented 3 months ago

Hi, thanks for the project! I made some changes, to make Fulguris better. Changes are:

Additional custom user agent check for new line breaks and tabulator. Fixes:

java.lang.IllegalArgumentException: HTTP headers must not contain null, CR, or NL characters. Invalid User-Agent 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36 Edg/122.0.2365.92

Make asking to run an external application by default. This has been a big problem for me. I used Fulguris for a while, but every time I get a weird bug with not opening intents. And once I deleted Fulguris because of that. Now I understand that it was because the apps opening flag was disabled by default in the domain settings.
Major refactor of the intent logic. Fixes #595. Also can now handle `browser_fallback_url' param. This param value of the URL will be opened if there is no activity available. Some other minor fixes.

Slion commented 3 months ago

Thanks, that's some really good contributions. Sorting out the intent stuff was long overdue. Though ideally we should have one pull request for each topic. I'll try to get this merged this week.

ZhymabekRoman commented 3 months ago

Though ideally we should have one pull request for each topic.

I can make separate PRs if it is really important. Probably, rebasing can partially solve this problem.

Slion commented 3 months ago

I can make separate PRs if it is really important. Probably, rebasing can partially solve this problem.

Don't worry for this one. I'll sort it out.

Slion commented 3 months ago

How did you test the intent changes? Could you describe the use cases?

ZhymabekRoman commented 3 months ago

How did you test the intent changes? Could you describe the use cases?

Basic test: https://t.me/durov, https://api.whatsapp.com/send?phone=91
Testing browser_fallback_url: open random Reddit page and press "Use App" button in top of the page. Example. If domain app settings set to "Yes" it should open Reddit, either if Reddit is not installed it's should open search page in Play Market with Reddit package name. If domain app settings set to "Ask", after pressing "No" in the message box, it's should trigger browser_fallback_url page. browser_fallback_url is just a Play Market page of the Reddit application.
https://play.google.com/store/apps/details?id=com.reddit.frontpage - If domain app settings set to "Ask" navigating Play Market page shouldn't trigger intent execution without user promt. After pressing "See in Play store" it's should open Play Market.

Slion commented 3 months ago

I merged all changes except the upload of build artefacts as that would result in publishing multiple builds with the same build numbers and I would like to avoid that. If that's something you really need I guess the solution could be to have another build variant. Open an issue about it if you want.