search

Slion / VirtualDesktop

C# wrapper for the Virtual Desktop API on Windows 11.
MIT License
21 stars 9 forks source link

All applications use the same generated DLL #12

Open Slion opened 1 year ago

Slion commented 1 year ago

All applications using VirtualDesktop use the same generated DLL from the app data folder. We should store it on a path specific to the running application to avoid conflicts.

Slion commented 1 year ago

Actually I don't think this is true. It might already be working properly.

Slion commented 1 year ago

This is definitely not an issue for packaged applications such as Taskbar where the generated assembly lands in such path: C:\Users\micro\AppData\Local\Packages\Slions.TaskbarTest_aarv4tknj59mw\LocalCache\Local\slions.net\VirtualDesktop\assemblies

However I wonder if this could be an issue for non-packaged applications such as our demo sample where the generated assembly land in such path: C:\Users\micro\AppData\Local\slions.net\VirtualDesktop\assemblies

mzomparelli commented 1 year ago

I think you're right every app would use the same dll, why would there be conflicts?

Why not generate the DLL next to the existing one where the users exe is? That way each app has to generate their own.

mzomparelli commented 1 year ago

I'm afraid generating next to the existing dll might not be a good idea if the user wants to create a single exe with no attached dlls. The original dll can be injected into the exe but the generated dll would be exposed. Might not be so bad if it removed the generated dll when the app shutdown.

mzomparelli commented 1 year ago

I think it's fine the way it is and I don't think apps using the same dll will cause a conflict.