Slipperybara / pe

0 stars 0 forks source link

Duplicate names are allowed when the letter capitalisation are different #4

Open Slipperybara opened 1 week ago

Slipperybara commented 1 week ago

Action:

 I accidentally added my friend's name again but now in all lower case

Expected result/output:

 the system helps me catch it

Actual result/output:
 the system allow the new name input, which means I have 2 objects of the same person in the system, which might cause confusion to me in the future

Screenshot:

 Screenshot 2024-11-15 at 4.44.12 PM.png

Suggestions: This is also mentioned in the UG. but I think that this issue could be fixed simply by making the names case insensitive

nus-pe-script commented 1 week ago

Team's Response

This bug is marked a duplicate of #1653 which also talks about the issue of names being case sensitive.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Names are made case sensitive

In the real world, a person with the name Alex Yeoh is likely to be the same person as alex yeoh, as such, names should not be made case sensitive, especially because typos are extremely common and could lead to unintentional duplicates.

image.png


[original: nus-cs2103-AY2425S1/pe-interim#697] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We believe this is a valid issue, but it is not in scope as we have already addressed this issue in the User Guide.

Furthermore, other functionalities we have implemented help to circumvent issues such as find, findgame which could help detect duplicates, and undo in the likely event of typos. For this reason, it is unlikely to affect normal operators and only cause a minor inconvenience to users.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]