SlippingGittys-Discord-Themes / Diskette

A tui-like Discord theme (Inspired by the Spotify "Text" theme)
Do What The F*ck You Want To Public License
87 stars 9 forks source link

Variouse UI issues #11

Closed cj2tech closed 2 months ago

cj2tech commented 2 months ago

:: Diskette Version:: 6.24

:: System Info:: Windows 11 64-bit (10.0.22631)

:: Discord Version :: Build Number: 309513

:: Theme Mod :: OpenAsar Nightly (5c875eb)

:: Current CSS in uses :: https://pastebin.com/HkLLBU38

:: Issue(s) ::

  1. Unable to scroll Server Browsers. was mention in https://github.com/SlippingGittys-Discord-Themes/Diskette/issues/10
  2. In friends upper container (think its div class="upperContainer_fc4f04') has no theme applied image
  3. Windows Close, minimize, and maximize buttons are misplaced image
  4. Unable to close any Reconnect/Streamer mode prompt due to misalignment. image

Hope all this helps. Love this theme. Been looking for a better them that is apart of that vapor-wave/cyberpunk theme and none could even hold a candle to this one. Would love to see the above fixed. Thanks for all the cool work and stuff. Also love the little Easter eggs that you put in the repo. ᵗᵃˢᵏ ᵐᵃⁿᵃᵍᵉʳ ⁱˢ ᵐᵃᵍⁱᶜᵃˡ ᵛᵘᵈᵒ.

Much love <3

TacticalDeux commented 2 months ago

(all changes to selector.css) the guild scrolling issue, for now, can be fixed by removing this entirely (or removing/changing only position, and fixing padding and positioning):

/* Guilds Placement */
.scroller_fea3ef {
  position: fixed !important;
  top: 20px !important; 
  padding-left: 10px !important; 
}

Title bar fix:

.theme-dark .themed_fc4f04 { /* was .themed_e44302 */
   background-color: var(--projectCabTitleBar);
   border: var(--borders);
   margin: 0 0 10px 10px;
   width: calc(100% - 25px);
   padding: 0px;
}

.theme-dark .themed_fc4f04:hover { /* was .themed_e44302 */
   border-color: var(--bordersH);
}

and this:

/* Friends Icon (Title Bar) */
.children_fc4f04>.iconWrapper_fc4f04{ /* was .children_e44302>.iconWrapper_e44302 */
   display: none;
}

And the title bar has now a kinda fade effect which gets left over and looks weird when making the bg transparent, so that can be removed by this:

/* Friends Title bar fade effect (why is this a thing) */
.children_fc4f04:after {
  display: none;
}

You can either wait for Vozy to fix these or, download selector.css making the changes/swaps, and change Diskette.theme.css to point to it

/*  🔌🔌🔌 Diskette Plugin - Do NOT Eject 🔌🔌🔌 */
@import url('path/to/file/here');

Or the far simpler and quicker way which is to add the fixes to your QuickCSS, and probably add !important at the end of all the attributes just to make sure there's no specificity issues, like this:

/* Friends Icon (Title Bar) */
.children_fc4f04>.iconWrapper_fc4f04{ /* was .children_e44302>.iconWrapper_e44302 */
   display: none !important;
}

Just remember to remove them once the theme gets fixed or it might fuck with future changes because of the !important flag.

nvkomata commented 2 months ago

hello @cj2tech @TacticalDeuce addressing issues:

  1. should be fixed in 768e8e7
  2. fixed after theme rewrite in 0b3fe30
  3. this is a behavior caused by the nature of the css addon itself - it makes the window buttons an overlay instead of being positioned in the titlebar at the top, so they may be overlayed on top of toolbar buttons on small window sizes. 2d82cc7 adds a background to them + futureproofness and a086170 fixes the positions
  4. fixed in 41bdcc6

lmk if any of these is still an issue

TacticalDeux commented 2 months ago

3 is still an issue for paddings higher/lower than 20, padding set to 20: image padding set to 10: image padding set to 30: image

and this really weird issue, at least on vesktop, is that everytime you open and close the dev tools the padding gets all messed up here's with the padding set to 20 and with dev tools opened and closed: image

TacticalDeux commented 2 months ago

everything (except the winbuttons and sidebar) seems to just go up a little, here's the entire ds client, no dev tools shenanigans: image here's the entire ds client with dev tools opened and closed: image

nvkomata commented 2 months ago

@TacticalDeuce

3 is still an issue for paddings higher/lower than 20

consider this a "wontfix" for now, we likely won't support changing the padding anymore or have an absolute vertical padding instead, as it's kind of a pain to work around it

and this really weird issue, at least on vesktop, is that everytime you open and close the dev tools the padding gets all messed up

i noticed this, you may make a seperate issue but just know that i'll be looking into it (however no promises on an actual fix since who knows what kind of curse has been placed upon this theme)

nvkomata commented 2 months ago

@TacticalDeuce

devtools breaking the content position should be fixed in dfdcf41 as i'm not able to reproduce it anymore

if you don't want to wait for the cdn to catch up on .github.io, you may use the github raw link

https://raw.githubusercontent.com/SlippingGittys-Discord-Themes/Diskette/main/User/Vozy/Documents/source%20files/diskette.css