SlippingGittys-Discord-Themes / surCord

A Discord Theme inspired by macOS & Human Interface Guidelines.
MIT License
74 stars 50 forks source link

Add Atom One Dark theme #37

Closed AchrafYndz closed 8 months ago

AchrafYndz commented 1 year ago

CSS to support Atom's One Dark theme.

SlippingGitty commented 1 year ago

Hi there! I like this color scheme, but there is a couple of changes I would like to make before upstreaming it. I hope you wouldn't mind taking a look at these changes I have made:

:root {
    --surCordBackground: rgb(40, 44, 52);
    --surCordBackground2: rgb(58, 63, 75);
    --surCordTextBackground: rgb(47, 52, 63);
    --surcordFriendsBackground: rgb(30, 34, 40);
    --surCordFriends: rgb(58, 63, 75);
    --surCordActiveNow: rgba(171, 178, 191, 0.3);
    --surCordGuilds: rgb(58, 63, 75);
    --surCordTitleBar: rgba(43, 49, 61, 1);
    --surCordSearch: rgb(47, 52, 63);
    --surCordHover: rgba(171, 178, 191, 0.1);
    --surCordBorder: rgb(63, 68, 74);
  }

  :root {
    --accent: rgb(100, 110, 130);
    --accent-hover: rgba(100, 110, 130, 0.977);
    --accent-selected: rgb(100, 110, 130, 0.612);
    --accent-focused: rgb(100, 110, 130, 0.2);
  }

How do you feel about these?

AchrafYndz commented 1 year ago

Hey,

It's definitely a good idea to use the rgb() format, rather than the hexadecimal encoding, to ensure consistency across all themes.

I'm not so sure about the addition of the --accent rule however. Whilst it does make the Discord icon in the top left look more coherent with the rest of the theme, it makes links in text messages pretty hard to read:

image

Perhaps it's a better idea to keep it a blue color, but rather than use the default Discord blue, we could change it to Atom One Dark's blue: rgb(97, 175, 239):

image image

The --accent-hover, --accent-selected and --accent-focused rules definitely made a huge improvement too.

:root {
    --surCordBackground: rgb(40, 44, 52);
    --surCordBackground2: rgb(58, 63, 75);
    --surCordTextBackground: rgb(47, 52, 63);
    --surcordFriendsBackground: rgb(30, 34, 40);
    --surCordFriends: rgb(58, 63, 75);
    --surCordActiveNow: rgba(171, 178, 191, 0.3);
    --surCordGuilds: rgb(58, 63, 75);
    --surCordTitleBar: rgba(43, 49, 61, 1);
    --surCordSearch: rgb(47, 52, 63);
    --surCordHover: rgba(171, 178, 191, 0.1);
    --surCordBorder: rgb(63, 68, 74);
  }

  :root {
    --accent: rgb(97, 175, 239); /* changed this to Atom One Dark's blue */
    --accent-hover: rgba(100, 110, 130, 0.977);
    --accent-selected: rgb(100, 110, 130, 0.612); /* shouldn't this be rgba? */
    --accent-focused: rgb(100, 110, 130, 0.2); /* shouldn't this be rgba? */
  }