SlobodanTodorovic / web_design_exercises

0 stars 1 forks source link

Vast #2

Open ilicmarko opened 3 years ago

ilicmarko commented 3 years ago

Thread za Vast projekat.

ilicmarko commented 3 years ago

HTML element nema padding ni marginu. To se nalazi na body-u

https://github.com/SlobodanTodorovic/web_design_exercises/blob/29803d3da133ae6b2b60b2232adc90e100c0027f/vast/vast.css#L3-L6

ilicmarko commented 3 years ago

https://github.com/SlobodanTodorovic/web_design_exercises/blob/29803d3da133ae6b2b60b2232adc90e100c0027f/vast/vast.css#L11

Kad god navodis fontove uvek na kraju trebas da navedes kojoj familiji pripada. Na primer

font-family: 'Source Sans Pro', Helvetica, sans-serif

https://developer.mozilla.org/en-US/docs/Web/CSS/font-family#%3Cgeneric-name%3E

ilicmarko commented 3 years ago

Trudi se da koristis jedan format boja.

https://github.com/SlobodanTodorovic/web_design_exercises/blob/29803d3da133ae6b2b60b2232adc90e100c0027f/vast/vast.css#L17

https://github.com/SlobodanTodorovic/web_design_exercises/blob/29803d3da133ae6b2b60b2232adc90e100c0027f/vast/vast.css#L50

ilicmarko commented 3 years ago

https://github.com/SlobodanTodorovic/web_design_exercises/blob/29803d3da133ae6b2b60b2232adc90e100c0027f/vast/vast.css#L76

Dugme ima border

ilicmarko commented 3 years ago

https://github.com/SlobodanTodorovic/web_design_exercises/blob/29803d3da133ae6b2b60b2232adc90e100c0027f/vast/vast.css#L99

Izbegavaj fiksne sirine i visine. Sadrzaj moze sam da diktira ove stvari.

https://github.com/SlobodanTodorovic/web_design_exercises/blob/29803d3da133ae6b2b60b2232adc90e100c0027f/vast/vast.css#L109

Trudi se da budes konzistentant sto se tice jedinica i izbegavaj ove predefinisane vrednosti.

ilicmarko commented 3 years ago

https://github.com/SlobodanTodorovic/web_design_exercises/blob/29803d3da133ae6b2b60b2232adc90e100c0027f/vast/vast.css#L162

Ovaj selektor je suvise genericki napisan i utice na sve elemente. Treba izbigavati ovakve selektore zato sto skoro uvek dovode do nezeljenog ponasanja.

Recimo sutra dan dodas paragraf unutar footera on nece da ima marginu ili bilo sta.

ilicmarko commented 3 years ago

https://github.com/SlobodanTodorovic/web_design_exercises/blob/29803d3da133ae6b2b60b2232adc90e100c0027f/vast/vast.html#L13

Button nema href attribut