Slothpala / RaidFrameSettings

GNU General Public License v2.0
4 stars 4 forks source link

Add the Aura Filter feature #28

Closed excorp closed 3 months ago

excorp commented 4 months ago

Blizzard Raid Frames have their own filters on auras, so sometimes I see auras that I want to hide, and sometimes I don't see auras that I want to see.

So I extended the previous blacklist feature and created a feature called aura filter. When you add an aura, the default value of show is false, so it will behave like a blacklist, and when you check show, it will behave like a whitelist.

In Blizzard's default settings, For example, "Amalgam's Seventh Spine"(item=136714) on a healer's trinket is buffed with "Fragile Echo"(spell=215267), will be displayed in the raid frame.

However, the buff "Touch of the Voodoo"(spell=266018) on the "Revitalizing Voodoo Totem"(item=158320) trinket will not be displayed. Or the "Ancient Protection"(spell=429271) buff on an "Leaf of the Ancient Protectors"(item=110009) trinket won't show up either.

I think we need this feature because the "Touch of the Voodoo" or "Ancient Protection" buffs are very traceable buffs and they are not showing up.

image image

Slothpala commented 3 months ago

Nice this is a much better soloution for blacklisting aswell! Have you ever run into any taint issues with hooking the function like this ?

excorp commented 3 months ago

I had a taint issue, but I'm not sure if it was related to this. I was creating and using additional frames to increase the number of aura frames displayed, but if I did anything to the default Blizzard aura frames, I would get an ADDON_ACTION_BLOCKED error, so I had to Hide() all of Blizzard's default aura frames, not just the additional ones, and create them separately.

I'll close this PR now that the relevant code has been added.