search

Slothpala / RaidFrameSettings

GNU General Public License v2.0
4 stars 4 forks source link

Blacklisted spells are hidden instead of resized and other fixes #5

Closed excorp closed 6 months ago

excorp commented 6 months ago
  1. hide blacklisted spells instead of resizing them
  2. increased the maximum number of buffs/debuffs (Default 10. Select from options)
  3. changed private aura location to match debuff location
  4. change the frame strata of debuffs (default Interited, can be changed in options)
Slothpala commented 6 months ago

Thank you for your contribution, but I cannot accept it at this stage. I only had a few minutes to test it in a dungeon run and found several problems.

  1. Settings did not apply correctly when using the menu without reloading. This is important for profiles to work as expected.
  2. I had ADDON_ACTION_BLOCKED errors.

When I find more time, I will review the code.

excorp commented 6 months ago

I fixed No.1.

I'll try to find the problem with No.2, but I don't know enough about addon development to know if I can find it.

excorp commented 6 months ago

I'm not familiar with github, so I thought it might be a problem that I did the pull request in the master branch, so I closed it. Whenever I made a commit to the forked master branch, it was automatically added to the pull request... and I still don't know how to fix the ADDON_ACTION_BLOCKED issue. I'll do some more research.