Slotos / passport-reddit

Reddit oauth2 authentication strategy for passport.js
Other
48 stars 24 forks source link

remove reddit state opinon line from README.md #13

Closed abdulhannanali closed 8 years ago

abdulhannanali commented 8 years ago

Hi!

No offence to @Slotos but state isn't a stupid requirement at all. It makes the authentication requests more secure and saves the user from attacks such as CSRF. Many modern day sites using OAuth 2.0 requires state including Google, Reddit as well as Medium. We shouldn't be advising or providing an opinion to the user on filing the issue. Sorry if the tone is harsh but README's better without it.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling e6f66e91490b22973f3d63b0495b38af0fd8a2d5 on abdulhannanali:patch-1 into dba01e9f41b0058bd1a3b2ff3621e7c94080fe90 on Slotos:master.