search

SloveniaEngineering / laguna-frontend

Laguna frontend source tree
Apache License 2.0
3 stars 1 forks source link

[FE] Auto-fill support on login #29

Closed kenpaicat closed 11 months ago

kenpaicat commented 11 months ago

Description

Login screen should support auto-fill features for autofilling with various password managers

zigapovhe commented 11 months ago

This should probably be closed as our custom CredentialTextField widget supports this out of the box. Will test that before closing this issue just to be sure

zigapovhe commented 11 months ago

Alright, CredentialTextField does support this, but I forgot to add AutofillGroup widget on LoginScreen.dart as parent widget of those CredentionTextFields. @amadejzr @Quiirex @anzbez Let me know which one of you wants to fix that. After adding this widget, please test if it works as expected with password manager of your choice

Quiirex commented 11 months ago

Alright, CredentialTextField does support this, but I forgot to add AutofillGroup widget on LoginScreen.dart as parent widget of those CredentionTextFields. @amadejzr @Quiirex @anzbez Let me know which one of you wants to fix that. After adding this widget, please test if it works as expected with password manager of your choice

I can look into it.

anzbez commented 11 months ago

Why not Auto-login? Or is that a part of it that comes by default?

zigapovhe commented 11 months ago

Why not Auto-login?

What kind of auto-login functionality do you have in mind? If your tokens are valid and not-yet expired, you will be automatically logged-in (this is already implemented). Hm.. ye maybe if user has checked "remember me" we can auto-login him with saved credentials even if tokens expired. If tokens are null (first login or user has logged-out) we keep him on login page. Is that what you had in mind?

anzbez commented 11 months ago

you will be automatically logged-in (this is already implemented)

My bad, I had a feeling that was the case 🤦‍♂️ .

zigapovhe commented 11 months ago

no problem :D. Thanks for the idea about auto-login haha. I think it we should discuss it in another issue. #31