SloveniaEngineering / laguna-frontend

Laguna frontend source tree
Apache License 2.0
3 stars 1 forks source link

Make recommended usernames selectable into username input field #33

Open kenpaicat opened 10 months ago

kenpaicat commented 10 months ago

Description

https://github.com/SloveniaEngineering/laguna-frontend/blob/6269b24ab879fdcf51f06870b66ed862da67ef42/lib/ui/screens/landing/registerScreen/registerScreen.dart#L72

zigapovhe commented 10 months ago

Something similar than what Reddit is doing? Maybe if we find any good dictionary list full of nouns and dictionary list full of adjectives and try randomly merging them together? Should be possible, but not for v1

kenpaicat commented 10 months ago

Currently 82436b5094b39622017a02e9f7ecf8ea636d3f2d implements recommendations by adding 3 recommended usernames of form "{username entered}(random number from 0 - 10000)" into a list. Then removes any username that already exists from that list, returning remainder via AlreadyExistsDTO (on BE).

Of course it can happen (although unlikely) that all 3 usernames already exist in which case no recommendations are sent.

So for v1 we kinda have a simple solution with random numbers.

This issue is low priority IMO?