search

Slowpoke101 / FTBLaunch

Launcher for the FTB Mod Pack
182 stars 140 forks source link

Useless parentheses around expressions should be removed to prevent any misunderstanding #965

Closed AymanDF closed 8 years ago

AymanDF commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:UselessParenthesesCheck - “ Useless parentheses around expressions should be removed to prevent any misunderstanding ”. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:UselessParenthesesCheck Please let me know if you have any questions. Ayman Abdelghany.

jikuja commented 8 years ago

Question for all Sonar rule PRs: are changes tested with java 6?

This PR is interesting and touched really old code. (no idea what earlier devs have been thinking. java x compatible code?)

There is few changes I personally dislike. I will comment those as line notes.

Ps. Most of the changes in this PR are find and makes code cleaner and should be merged at some point.