Slowpoke101 / FTBLaunch

Launcher for the FTB Mod Pack
183 stars 140 forks source link

RAM Flag #987

Open Slowpoke101 opened 7 years ago

Slowpoke101 commented 7 years ago

Add a flag to notify players that they need to increase RAM

progwml6 commented 7 years ago

this is meant to notify about work to get done.... whoever codes this(if i don't get to it first) please speak to me

jikuja commented 7 years ago

What are we talking here here:

I'm not sure if -Xms should be used at all. Performance gain?

progwml6 commented 7 years ago

xms will be covered in #988

this is really meant to ensure that newer high ram packs inform & allow users to increase ram in a dialog if the current value is too low and the system supports a higher ram value

total ram and xmx will need to be checked similar to the existing 32 bit ram maximization code. either we allow people to increase the xmx via a slider(like what's in options, and hooked into that same setting) or we increase it to 512mb above the minimum setting in the xml (if it exists)

if no setting exists in the xml default to current values

if the user's machine doesn't have enough ram warn them that they probably won't be able to play the pack.

we will need to consider if we are going to pop the boxes up again if they don't increase the ram above the threasholds or not in the same pack

progwml6 commented 7 years ago

i've added minClientRam to the xml support code in the launcher. Its not in the api yet(in case anybody uses the xml>json stuff on there)

progwml6 commented 7 years ago

info on where to look to complete these changes https://github.com/Slowpoke101/FTBLaunch/commit/7965f93b6b88e4a28e3d5bbd982c4ffb9203355a