Implement fob pairing functionality - [merged]

[eggroll-bot]

Merges fob-pairing -> main

This merge request implements pairing between the pairing host tool, paired fob, and unpaired fob.

Closes #5.

[eggroll-bot]

requested review from @MelonShooter

[eggroll-bot]

added 1 commit

• 10c339de - Switch to new message typing

Compare with previous version

[eggroll-bot]

added 2 commits

• e5a5d0f9 - Increase opt-level for binary size to allow for new code
• 63d87244 - Start working on pairing

Compare with previous version

[eggroll-bot]

added 1 commit

• 08f5a4a1 - Change opt-level to "z"

Compare with previous version

[eggroll-bot]

added 1 commit

• 6a4c8e59 - Move lto option

Compare with previous version

[eggroll-bot]

added 1 commit

• 1c293b70 - Get ephemeral public key, add lto

Compare with previous version

[eggroll-bot]

added 1 commit

• 9168b750 - Finish generating secret on unpaired side

Compare with previous version

[eggroll-bot]

added 1 commit

• 26127d11 - Improve zeroizing logic

Compare with previous version

[eggroll-bot]

added 1 commit

• 0c585b09 - Switch to SEC1 for transmissions

Compare with previous version

[eggroll-bot]

added 1 commit

• 1ba01c1c - Reorganize Diffie-Hellman code

Compare with previous version

[eggroll-bot]

added 1 commit

• 5eebcc0a - Finish unpaired side of Diffie-Hellman

Compare with previous version

[eggroll-bot]

added 1 commit

• 1aa0420b - Add paired longer cooldown byte to EEPROM, update optimization flags

Compare with previous version

[eggroll-bot]

added 1 commit

• 22c83e0e - Finish Diffie-Hellman exchange

Compare with previous version

[eggroll-bot]

added 5 commits

• 22c83e0e...6fba3cb6 - 4 commits from branch main
• 6553af29 - Add pairing code

Compare with previous version

[eggroll-bot]

added 1 commit

• d7e2c70e - Decrease timeout time to 4950 ms for host tool

Compare with previous version

[eggroll-bot]

added 1 commit

• c3dac0e2 - Split pairing into modules, clean up code

Compare with previous version

[eggroll-bot]

added 1 commit

• 31e857ff - Finish half of pairing sequence

Compare with previous version

[eggroll-bot]

added 1 commit

• efe083e5 - Refactor pairing sequence

Compare with previous version

[eggroll-bot]

added 1 commit

• 1ef63aa3 - Finish pairing sequence on paired side

Compare with previous version

[eggroll-bot]

added 1 commit

• 11bcfa1b - Loop receiving of paired ephemeral public key after sending

Compare with previous version

[eggroll-bot]

marked this merge request as ready

[eggroll-bot]

@victorh12 @jzhan357, please review as well.

[eggroll-bot]

In GitLab by @victorh12 on Feb 27, 2023, 18:32

Commented on fob/src/pairing/diffie_hellman.rs line 259

It's possible for this to take longer than 1 second and still return a key since recv_verified_ephemeral_public_key uses a timeout of 1000 seconds.

[eggroll-bot]

In GitLab by @victorh12 on Feb 27, 2023, 18:32

Commented on fob/src/pairing/pairing_sequence.rs line 22

This should be UART1.

[eggroll-bot]

In GitLab by @victorh12 on Feb 27, 2023, 18:32

Commented on fob/src/pairing/diffie_hellman.rs line 211

/// Performs the Diffie-Hellman key exchange as an unpaired key fob and sets the UART1 channel key.

[eggroll-bot]

In GitLab by @victorh12 on Feb 27, 2023, 18:32

Commented on fob/src/pairing/diffie_hellman.rs line 252

/// Performs the Diffie-Hellman key exchange as a paired key fob and sets the UART1 channel key.

[eggroll-bot]

In GitLab by @victorh12 on Feb 27, 2023, 18:32

Commented on fob/src/pairing/diffie_hellman.rs line 266

    // Send Diffie-Hellman message to unpaired key fob.

[eggroll-bot]

In GitLab by @victorh12 on Feb 27, 2023, 18:34

Commented on fob/src/pairing/diffie_hellman.rs line 277

    // Receive ephemeral public key from unpaired key fob.

[eggroll-bot]

changed this line in version 20 of the diff

[eggroll-bot]

added 1 commit

• 2a66d2b7 - Make fixes to pairing

Compare with previous version

[eggroll-bot]

resolved all threads

[eggroll-bot]

resolved all threads

[eggroll-bot]

changed this line in version 21 of the diff

[eggroll-bot]

changed this line in version 21 of the diff

[eggroll-bot]

changed this line in version 21 of the diff

[eggroll-bot]

changed this line in version 21 of the diff

[eggroll-bot]

added 1 commit

• 2f9d066b - Apply 4 suggestion(s) to 1 file(s)

Compare with previous version

[eggroll-bot]

In GitLab by @victorh12 on Feb 27, 2023, 23:44

approved this merge request

[eggroll-bot]

added 1 commit

• 0f4d1025 - Change to VerifyingKey for build script update

Compare with previous version

[eggroll-bot]

added 13 commits

• 0f4d1025...822a7fe0 - 3 commits from branch main
• c912cbc9 - Add pairing code
• fe15db1d - Decrease timeout time to 4950 ms for host tool
• 15aeff38 - Split pairing into modules, clean up code
• 841302e9 - Finish half of pairing sequence
• 0d7303e5 - Refactor pairing sequence
• 75f3f1e1 - Finish pairing sequence on paired side
• 373638a7 - Loop receiving of paired ephemeral public key after sending
• bf005596 - Make fixes to pairing
• 3871e5f7 - Apply 4 suggestion(s) to 1 file(s)
• 0c68a08e - Change to VerifyingKey for build script update

Compare with previous version

[eggroll-bot]

In GitLab by @jzhan357 on Feb 28, 2023, 01:46

Commented on fob/src/pairing/diffie_hellman.rs line 52

Use VerifyingKey instead of PublicKey.

[eggroll-bot]

In GitLab by @jzhan357 on Feb 28, 2023, 01:46

Commented on fob/src/pairing/diffie_hellman.rs line 70

Use VerifyingKey instead of PublicKey.

[eggroll-bot]

changed this line in version 24 of the diff

[eggroll-bot]

added 1 commit

• 4249c6c3 - Switch PublicKey to VerifyingKey

Compare with previous version

[eggroll-bot]

resolved all threads

[eggroll-bot]

In GitLab by @MelonShooter on Feb 28, 2023, 02:37

Commented on fob/src/pairing/diffie_hellman.rs line 21

This function is 70 lines long. Take each comment you made and make them their own self-describing function

[eggroll-bot]

In GitLab by @MelonShooter on Feb 28, 2023, 02:37

Commented on fob/src/pairing/diffie_hellman.rs line 63

This sequence of verifying a signature of a key should probably be made as a member function of VerifiedPublicKey or whatever that struct is called. That way it can be used here for easier for both this and verifying the signature of the ephemeral public key

[eggroll-bot]

In GitLab by @MelonShooter on Feb 28, 2023, 02:37

Commented on fob/src/pairing/diffie_hellman.rs line 87

This general pattern of getting a public key from a VerifiedPublicKey or whatever it was called should be generalized and made a method within that struct.

[eggroll-bot]

In GitLab by @jzhan357 on Feb 28, 2023, 02:38

Commented on fob/src/pairing.rs line 3

Shouldn't this be named unpaired_process_msg to match the other function name?

[eggroll-bot]

In GitLab by @MelonShooter on Feb 28, 2023, 03:13

Commented on fob/src/pairing/diffie_hellman.rs line 203

This can probably be the same code you have in run_paired with the loop. Double check that this is functionally sound.