search

Slumber86 / express-oracle-session

An Oracle session store for express
MIT License
1 stars 10 forks source link

support passing of PoolAlias to oracledb.getconnection #3

Open Pollocks01 opened 7 years ago

Pollocks01 commented 7 years ago

You pass the passed 'options' to oracledb.createPool which means that we can set createPool related options. Once such option supported by oracledb is poolAlias. You go on to oracledb.getConnection and by not passing a poolAlias, you hardcode to use the 'default' pool. Your solution would be more robust if you instead oracledb.getconnection(options.poolAlias || 'default'......

cheers!

Slumber86 commented 7 years ago

can do the fix in the next days..

Pollocks01 commented 7 years ago

Agostino, that's excellent. If I can find the time to figure out how to submit patches etc, I will.

Thanks,

Paul

Slumber86 commented 7 years ago

You can make a pull request..

On 14 Jun 2017, 01:12 +0200, Pollocks01 notifications@github.com, wrote:

Agostino, that's excellent. If I can find the time to figure out how to submit patches etc, I will. Thanks, Paul — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.