SlyAceZeta / Ribbons.Guide

Keep track of your Pokémon's Ribbons!
https://ribbons.guide/
GNU General Public License v3.0
22 stars 2 forks source link

Multiple language support #20

Open SlyAceZeta opened 1 year ago

SlyAceZeta commented 1 year ago

Japanese especially, obviously, but a modular system to allow for multiple translations would be handy. If someone has not selected a language, we could have a modal pop-up when they first enter the site and then have it also accessible from the settings modal.

SadisticMystic commented 1 year ago

PKHeX has the relevant strings for this arranged at https://github.com/kwsch/PKHeX/tree/master/PKHeX.Core/Resources/text/other . Most of them should be easy to parse, except the list of forms for when you get around to that.

SadisticMystic commented 1 year ago

In German, as well as the Asian languages, the title associated with a ribbon is placed before the Pokemon's name, rather than afterward as it does in ENG/FRE/SPA/ITA. Is it worth creating an extra semantic property for each language and possibly reversing the placement of name and title if a language is set that calls for it?

SlyAceZeta commented 1 year ago

In German, as well as the Asian languages, the title associated with a ribbon is placed before the Pokemon's name, rather than afterward as it does in ENG/FRE/SPA/ITA. Is it worth creating an extra semantic property for each language and possibly reversing the placement of name and title if a language is set that calls for it?

I've moved this to #43 as it's a related but separate issue.