Better automatic handling of blue/gold memory Ribbons

[SlyAceZeta]

https://discord.com/channels/1080506053101375579/1103502469029433465

If at least one old battle/contest Ribbon is selected, but not all of them, but the blue and gold memory Ribbons are both selected, then prioritize the blue instead of the current behavior of always prioritizing the gold.

In addition, the World Ability Ribbon all 8 Tower Ribbons are not required anymore in Scarlet/Violet for the gold Battle Memory Ribbon, just 7, so maybe we should consider removing that requirement as well, or making it an option (tied into #46).

EDIT: Rework the whole logic per https://github.com/Azekthi/Ribbons.Guide/issues/66#issuecomment-1712787221

[Selliato]

Just to clarify : This is not specifically the world ability ribbon that's not required, detail of old battle ribbons aren't present in Pokemon data anymore except the total number, the requirement for the gold battle memory ribbon it's 39 old battle ribbons no matter which.

[SlyAceZeta]

Thank you, I forgot that it wasn't specifically World Ability, just one less than the maximum. autumn on Discord also clarified this back when the SV<>HOME update released.

I'm just gonna barf up my thinking process here. I'm planning a large backend rewrite anyway, so we might as well start over with how we handle these Ribbons.

Create a new setting: "Automatic handling of Memory Ribbons"

• If the setting is enabled (default) and the Pokemon does not have the Memory Ribbons manually selected, R.G will calculate which ones need to be displayed.
  • Battle Memory:
  • If the current game is Scarlet and Violet, if at least seven Tower Ribbons are selected, display the gold Battle Memory Ribbon, otherwise display the blue one.
  • If the current game is Gen VII, if at least one Tower Ribbon and at least seven other Ribbons are selected, display the gold Battle Memory Ribbon, otherwise display the blue one.
  • In all other Gen VI+ games, if all eight Tower Ribbons are selected, display the gold Battle Memory Ribbon, otherwise display the blue one.
  • Contest Memory: In all Gen VI+ games, if all 40 Contest Ribbons are selected, display the gold Contest Memory Ribbon, otherwise display the blue one. (The Gen VII display bug isn't possible to see legitimately, so we don't need to account for it.)
• If the setting is disabled or the Pokemon has the Memory Ribbons manually selected, they will be shown verbatim.
• Regardless of setting, Memory Ribbons will not appear in the checklist anymore.