search

SlyMarbo / rss

A Go library for fetching, parsing, and updating RSS feeds.
Other
400 stars 85 forks source link

Fix the image compatible issue #77

Closed LinuxSuRen closed 2 years ago

LinuxSuRen commented 2 years ago

I found a potential image issue of the RSS parsing process. See the details below:

An image to associate with your podcast. It must not be blocked to Googlebot. You can provide an image using any of the following tags:

<itunes:image>
<image>
  <link>...</link>
  <title>...</title>
  <url>...</url>
</image>
When using RSS <image> tags, you must include a nested <link> element that points to the podcast homepage, and a nested <title> tag that matches the <title> element in the homepage.

Example: <itunes:image href="https://google.com/google_podcast_cover_art.jpg"/>

Reference

SlyMarbo commented 2 years ago

Hi @LinuxSuRen . Thanks for your contribution! It looks great and I'm very happy to merge the code changes.

Would it be possible to remove the change to .gitignore? I prefer to avoid anything not specific to this codebase. If it helps, you can put common things in a global .gitignore outside the repository, configured using git config --global core.excludesfile ~/.gitignore.

LinuxSuRen commented 2 years ago

hi @SlyMarbo , thanks for your excellent suggestion. It helps a lot.

LinuxSuRen commented 2 years ago

By the way, I'm trying to create an open-source podcast platform based on Kubernetes. I am not sure if you are interested in it. Please ignore it if you don't.

SlyMarbo commented 2 years ago

That sounds really cool! I'm afraid podcasts aren't really my thing, but I wish you the best of luck.

LinuxSuRen commented 2 years ago

Thanks for your time. I'm wondering if it's possible to have a new git tag. For example: v1.0.2. So others can use this feature as a tag instead of a branch.