search

SlyMarbo / spdy

[deprecated] A full-featured SPDY library for the Go language.
BSD 2-Clause "Simplified" License
116 stars 13 forks source link

a little refactoring to simplify readFrames #30

Closed cpg closed 11 years ago

cpg commented 11 years ago

factoring some things out of readFrames to simplify understanding what's going on

SlyMarbo commented 11 years ago

I appreciate that readFrames does need to be improved, but these changes are not in keeping with the current naming scheme and does lose some subtle functions. I'll do equivalent refactoring.

cpg commented 11 years ago

ok. truth be told, i was not paying much attention to the pattern of names for functions, so yeah, it's better to have similar names.

I just noticed something else. In reading more, there is this piece of code that might be calling the previous function i suggested, if it were not for the last check for err == ErrConnNil, and the message. is that something that the other function i suggested might benefit from as well? (once you do your equivalent refactoring).

SlyMarbo commented 11 years ago

Yes, well spotted. I'm about to push the changes.