search

Slyyxp / rsack

Ransack「rsack」is a lossless Korean music downloader
MIT License
84 stars 12 forks source link

Label (id3.TPUB) not supported. #33

Closed steamgirl2020 closed 2 years ago

steamgirl2020 commented 2 years ago

The bug's metadata does not support label tags, showing blank，but BugsPy-master support

Slyyxp commented 2 years ago 
    meta = {
        "ALBUM": track['album_title'],
        "ALBUMARTIST": track['artist_disp_nm'],
        "ARTIST": track['artist_disp_nm'],
        "TITLE": track['track_title'],
        "DISCNUMBER": str(track['disc_id']),
        "DISCTOTAL": str(album['disc_total']),
        "TRACKNUMBER": str(track['track_no']),
        "TRACKTOTAL": str(track['track_total']),
        "COMMENT": str(track['track_id']),
        "DATE": _format_date(track['release_ymd']),
        "GENRE": album['genre_str'],
        "LABEL": "",
        "LYRICS": lyrics
    }

Label was left blank here. I can't recall whether was a reason or not I left it blank or whether I just overlooked.

Will look into it.

Slyyxp commented 2 years ago

I have put forward a fix based on my previous code. It is available temporarily on a new branch until it has been confirmed to be fixed. https://github.com/Slyyxp/rsack/tree/Slyyxp-Patch-1

I do not have an account to test with so I would appreciate if someone can indicate to me whether this works as intended.

steamgirl2020 commented 2 years ago

not fixed：( I downloaded https://codeload.github.com/Slyyxp/rsack/zip/refs/heads/Slyyxp-Patch-1

Slyyxp commented 2 years ago

I'll take your word for it. I won't be paying for another Bugs account in near future so I can't fix this for now.

Someone else can take a look at the meta and see what needs to be appended if they want.

Slyyxp commented 2 years ago

Got my hands on an account so was able to fix this. Labels are now properly added to both FLAC and MP3

e0f873bc4f990cb2ca141bc26a6daf96d406a837