Slyyxp / rsack

Ransack「rsack」is a lossless Korean music downloader
MIT License
84 stars 12 forks source link

FLAC false positive. #47

Closed Slyyxp closed 1 year ago

Slyyxp commented 1 year ago

API returns that there is FLAC present, yet it redirects to MP3. This could be because of the streaming plan, it is unknown why.

Slyyxp commented 1 year ago

6c4b948d6b77721c545058524227d5fcbd23c48d

Kukuair commented 1 year ago

the problem still exists,for example this album https://music.bugs.co.kr/album/17543598?wl_ref=list_ab_03_ab

Slyyxp commented 1 year ago

I fail to see any error in this album. For me this album is completely FLAC as shown on the webpage.

If you're experiencing any error (or unexpected behaviour) with this one then post the traceback alongside the version you're using.

Kukuair commented 1 year ago
``` PS C:\Users\so_nu\Desktop> rsack -b -u "https://music.bugs.co.kr/album/17543598?wl_ref=list_ab_03_ab" 2022-09-12 08:34:24.399 | INFO | rsack.clients.bugs:auth:29 - Login Successful 2022-09-12 08:34:24.401 | INFO | rsack.bugs:__init__:25 - Threads: 1 2022-09-12 08:34:24.836 | INFO | rsack.bugs:_album:60 - Album: Real Love 2022-09-12 08:34:24.851 | DEBUG | rsack.bugs:_album_path:81 - Creating C:\Users\so_nu\Desktop\오마이걸(OH MY GIRL) - Real Love 2022-09-12 08:34:25.395 | INFO | rsack.bugs:_download_cover:179 - Cover artwork downloaded. 2022-09-12 08:34:25.397 | INFO | rsack.bugs:_download:100 - Track: Real Love 2022-09-12 08:34:28.287 | DEBUG | rsack.bugs:_tag:226 - Writing tags to C:\Users\so_nu\Desktop\오마이걸(OH MY GIRL) - Real Love\1. Real Love.mp3 2022-09-12 08:34:28.303 | INFO | rsack.bugs:_download:100 - Track: Drip 2022-09-12 08:34:30.757 | DEBUG | rsack.bugs:_tag:226 - Writing tags to C:\Users\so_nu\Desktop\오마이걸(OH MY GIRL) - Real Love\2. Drip.mp3 2022-09-12 08:34:30.763 | INFO | rsack.bugs:_download:100 - Track: Eden 2022-09-12 08:34:34.340 | DEBUG | rsack.bugs:_tag:226 - Writing tags to C:\Users\so_nu\Desktop\오마이걸(OH MY GIRL) - Real Love\3. Eden.mp3 2022-09-12 08:34:34.346 | INFO | rsack.bugs:_download:100 - Track: Replay 2022-09-12 08:34:36.708 | DEBUG | rsack.bugs:_tag:226 - Writing tags to C:\Users\so_nu\Desktop\오마이걸(OH MY GIRL) - Real Love\4. Replay.mp3 2022-09-12 08:34:36.714 | INFO | rsack.bugs:_download:100 - Track: Parachute 2022-09-12 08:34:38.900 | DEBUG | rsack.bugs:_tag:226 - Writing tags to C:\Users\so_nu\Desktop\오마이걸(OH MY GIRL) - Real Love\5. Parachute.mp3 2022-09-12 08:34:38.906 | INFO | rsack.bugs:_download:100 - Track: Kiss & Fix 2022-09-12 08:34:41.557 | DEBUG | rsack.bugs:_tag:226 - Writing tags to C:\Users\so_nu\Desktop\오마이걸(OH MY GIRL) - Real Love\6. Kiss & Fix.mp3 2022-09-12 08:34:41.564 | INFO | rsack.bugs:_download:100 - Track: Blink 2022-09-12 08:34:44.067 | DEBUG | rsack.bugs:_tag:226 - Writing tags to C:\Users\so_nu\Desktop\오마이걸(OH MY GIRL) - Real Love\7. Blink.mp3 2022-09-12 08:34:44.074 | INFO | rsack.bugs:_download:100 - Track: Dear Rose 2022-09-12 08:34:47.268 | DEBUG | rsack.bugs:_tag:226 - Writing tags to C:\Users\so_nu\Desktop\오마이걸(OH MY GIRL) - Real Love\8. Dear Rose.mp3 2022-09-12 08:34:47.274 | INFO | rsack.bugs:_download:100 - Track: Sailing Heart (항해) 2022-09-12 08:34:50.525 | DEBUG | rsack.bugs:_tag:226 - Writing tags to C:\Users\so_nu\Desktop\오마이걸(OH MY GIRL) - Real Love\9. Sailing Heart (항해).mp3 2022-09-12 08:34:50.543 | INFO | rsack.bugs:_download:100 - Track: Real Love (Inst.) 2022-09-12 08:34:53.125 | DEBUG | rsack.bugs:_tag:226 - Writing tags to C:\Users\so_nu\Desktop\오마이걸(OH MY GIRL) - Real Love\10. Real Love (Inst.).mp3 ```

I recorded two videos, one was successfully downloaded in flac format and the other was downloaded in mp3 format,I tried uploading these videos to youtube, but after uploading, the quality of the video was reduced, the video became blurry, I had to upload them to google cloud drive, if you watch it online it will still use youtube to play, the quality will still very blurry. you can download it locally for viewing

https://drive.google.com/drive/folders/1tuDCJehyRIGwoSsIwWMq5Fa6WY7L1X7r?usp=sharing

Slyyxp commented 1 year ago

Locking this issue as I am confident false positives are handled properly.

Slyyxp commented 1 year ago

the problem still exists,for example this album https://music.bugs.co.kr/album/17543598?wl_ref=list_ab_03_ab

This is an unrelated issue caused by inssuficient streaming plan.