Slyyxp / rsack

Ransack「rsack」is a lossless Korean music downloader
MIT License
85 stars 14 forks source link

Update kkbox.py #79

Closed Kukuair closed 1 year ago

Kukuair commented 1 year ago

I try to download all albums of an artist, but only the albums shown in https://play.kkbox.com/artist/XXXXXXXXXXXXXX will be downloaded.

![image](https://user-images.githubusercontent.com/57177286/211818532-c445743c-9282-40a0-a433-ac841868aada.png)

But this is only a part of this artist's albums, not all of this artist's albums. his all albums are showcased at https://play.kkbox.com/artist/xxxxxxxxxxxxxx/albums. and should use “get_artist_albums” function to download from here

![image](https://user-images.githubusercontent.com/57177286/211819694-52362a4d-e68c-4f8f-9f04-ac1823fc460a.png) ![image](https://user-images.githubusercontent.com/57177286/211819000-4e41a034-9f8f-4ccf-b014-739b706bd1de.png)

In addition, you seem to use the 'get_date' function in ' rsack\clients\kkbox.py ' to capture the release time of the album through ' Beautifulsoup'. Actually, the release time of the album can also be obtained from 'get_artist_albums' I feel that it is only suitable for batch downloading all albums of an artist. If only one album is downloaded, the current method is more convenient

(I have the log print out the name of the album currently being downloaded, so it looks a little clearer)

hope there is nothing wrong

Slyyxp commented 1 year ago

Bs4 is indeed used as I could not find the date anywhere in the API response. I will review this when I have time.