search

SmArtKar / EnhancedBeliefs

Creative Commons Attribution 4.0 International
0 stars 1 forks source link

[BUG] No job authors makes religious book uncreatable #7

Open KissKonradUni opened 2 months ago

KissKonradUni commented 2 months ago

Just as the title says there's no way for the pawns to finish a religious book if the no job authors mod is enabled, no one will be able to write it. There are no errors in the console, and there are no options to finish it on a workstation or by clicking the item. I have Performance Fish and Rocketman enabled in my regular run, but as I tried without them the bug still remains so I'm pretty sure it's the missing author that creates the bug.

delmain commented 1 month ago

Ah, yeah, I just commented on this on the mod itself before seeing the request to come to Github.

The issue appears to be that since the Creator is overridden to always be null on UnfinishedThing, then the book itself can't pick it's Ideo.

In Inspiration_ReligiousBook, the book's Creator is set, but it's Ideo isn't, and then later on it tries to set it's own Ideo based on the Creator. Since Creator is null, it just fails and never sets an Ideo and can never be finished.

If you change Inspiration_ReligiousBook to set the Ideo on the UnfinishedReligiousBook in addition to the Creator, everything would work fine (I think).