search

SmBe19 / ThunderbirdTodoist

Thunderbird Add-On for Todoist
MIT License
45 stars 6 forks source link

added message content #14

Closed Marlon154 closed 2 years ago

Marlon154 commented 2 years ago

DO NOT MERGE! TEST FIRST!

SmBe19 commented 2 years ago

Thanks!

I think it would be great to have an option in the settings to enable or disable this, by default I would suggest to have this turned off. Some users might not want to have the complete message to every task.

Marlon154 commented 2 years ago

I think the text for the checkbox is missing

Marlon154 commented 2 years ago

sorry for the mess! BTW the windows instructions for the mail link works on my machine

Marlon154 commented 2 years ago

@SmBe19

SmBe19 commented 2 years ago

Sorry, as I said, I first needed to test this locally and I did not have time until now.

When testing locally it turned out that nothing worked and I had to rework quite a lot of it to get it working. The changes are now merged.

Just as a short remark for future PRs: I would expect you to actually test the changes locally before opening a PR. And when implementing PR feedback it would be nice to double check your changes before pushing a change, this would save both yourself and the maintainer some time.

Marlon154 commented 2 years ago

okay yeah I know but I did not had a chance to test it locally