SmItH197 / SteamAuthentication

A simple PHP Authentication that enables steam users to log into their steam account to access content!
MIT License
446 stars 147 forks source link

Removed spaces after PHP close tag #233

Open BearWoolley opened 5 years ago

BearWoolley commented 5 years ago

Blank line and spaces at the end of the file caused errors to be thrown such as: Warning: require(SteamConfig.php): failed to open stream: No such file or directory in ...

Removing the line at the end of the file fixes this.

BlackCetha commented 5 years ago

A newline at the end of a PHP script will not throw errors about missing files.

BearWoolley commented 5 years ago

It's a new line with 4 blank spaces, which in some cases causes PHP errors.

I've only had a few issues with it, but it's something that keeps getting reported to me and to fix it I have to get them to remove those 4 blank lines and the error disappears.

RedSparr0w commented 5 years ago

It's strange that this would be causing those errors for you, but either way +1 on the PR.

Although wouldn't you be better off removing the entire closing php tag

-?>
-    
BlackCetha commented 5 years ago

Can you provide a way to reproduce your problems?