SmajloSlovakian / Minecraft-Smooth-Scrolling

Scroll smoothly
GNU General Public License v3.0
7 stars 2 forks source link

[Incompatibility] Creative menu search has an issue when using the Sounds mod. #46

Closed DmanMC closed 2 months ago

DmanMC commented 4 months ago

When using the Sounds mod, whenever the creative search menu is filled to the last line, there is a nonstop scroll sound.

For example when searching "cre":

https://github.com/user-attachments/assets/fedf2a96-aa06-4588-86cc-7a7b0ab43d3a

When searching "woo":

https://github.com/user-attachments/assets/f9b24342-debe-4cca-b5ba-4e057b749164

DmanMC commented 4 months ago

it appears the dev of the sounds mod said they were going to contact you, sorry if they already did :p

SmajloSlovakian commented 4 months ago

they didn't yet... i'm going to investigate the issue and see what can be done by me and/or them

SmajloSlovakian commented 4 months ago

ok so i don't know why it spams scrollItems() only when there are exactly 5 rows of items in the tab... i use scrollitems() to update the slots so the correct items show up there at correct times so it should be clicking almost always when you have scrolled at least once without changing tabs / search filter but not when stationary as the sounds mod does check if the scroll position is the same as before or not... gonna look into it more later

SmajloSlovakian commented 3 months ago

this is now fixed... it isn't perfect but at least it isn't annoying (i think)... further fixing would be a bit hard, so i'm marking this as fixed

SmajloSlovakian commented 2 months ago

partially resolved in update 2.1.3... no further resolving will be done