We currently have a lot of logic baked into ObjectsHelper.gd -- this worked okay initially when there was only one thing that were being added and its configuration was fairly simple.
Already though we've expanded to add: Moveable blocks, NPCs, Items, and Switches.
IMO we have two refactors to make this less prone to collapsing under its own weight:
rework moveable blocks, NPCs, and Items to follow the model of Switches that uses a sub-scene for configuration
rework the object addition path to be generic and uniform across each item being added
1 should be pretty straight forward and if we have to cut 2 in order to keep the PR reasonable that's fine but we should file a follow up issue in that case to handle wrapping it up.
We currently have a lot of logic baked into
ObjectsHelper.gd-- this worked okay initially when there was only one thing that were being added and its configuration was fairly simple.Already though we've expanded to add: Moveable blocks, NPCs, Items, and Switches.
IMO we have two refactors to make this less prone to collapsing under its own weight:
1 should be pretty straight forward and if we have to cut 2 in order to keep the PR reasonable that's fine but we should file a follow up issue in that case to handle wrapping it up.