search

SmallLars / openssl-ccm

Ruby Gem for RFC 3610 - Counter with CBC-MAC (CCM)
rubygems.org/gems/openssl-ccm
MIT License
2 stars 6 forks source link

Version 1.2.2 #5

Closed SmallLars closed 5 years ago

SmallLars commented 5 years ago

@jooeycheng @franee

My current system is using lower case letters to =o

Any reasons why I should not publish the current master as version 1.2.2?

SmallLars commented 5 years ago

Ill fix #6 before.

jooeycheng commented 5 years ago

~hey @SmallLars, I'm not understanding the question. It seems that current master is already published as v1.2.1. (perhaps i missed something?)~

~What changes would v1.2.2 bring?~

EDIT: Oh, sorry 🤦‍♂️. My bad. I thought v1.2.1 was the latest, with the lowercase cipher fix bcos it shows as released on 6 Jan 2019 on GitHub. However, v1.2.1 is actually the current production release on RubyGems, which was published in 2015.

So, v1.2.2 refers to the lowercase fix! Hmm, I don't see any reason why not to. I've verified the fix is backwards compatible by running it on CircleCI (the lowercased ciphers), and on my local machine (the uppercased ciphers).

@franee any comments?

jooeycheng commented 5 years ago

@SmallLars

My current system is using lower case letters to =o

What version of openssl are u running? The version on my CircleCI was OpenSSL 1.1.0j 20 Nov 2018.

I'm still unsure on the root cause, bcos I'm unable to understand how OpenSSL::Cipher.ciphers get its cipher list. 🤔

SmallLars commented 5 years ago

I am using Manjaro Linux. ruby 2.5.3p105 (2018-10-18 revision 65156) [x86_64-linux] OpenSSL 1.1.1 11 Sep 2018.

I thought v1.2.1 was the latest, with the lowercase cipher fix bcos it shows as released on 6 Jan 2019 on GitHub.

Yes, I added the missing tags, sorry. Sad that GitHub do not use the date of the commits the tags pointing to.