Broken x86/console template, dirty tty code

GoogleCodeExporter commented 9 years ago

- change in build.lds 'CROSS_COMPILE = i486-elf-'
- svn updated
make clean
make PROJECT=x86 PROFILE=console
make all

Some dependencies goes wrong...

Processing dependencies (cycle detection is OFF)
./src/cmds/Makefile:1: warning:  Undefined dependencies [DEPS] for unit 
embox.cmd.flashinfo:: embox.driver.flash
./src/cmds/Makefile:1: warning:  Undefined dependencies [DEPS] for unit 
embox.cmd.store:: embox.driver.flash
./src/fs/romfs/Makefile:1: warning:  Undefined dependencies [DEPS] for unit 
embox.fs.partition:: embox.driver.flash
./src/service/bluetooth/Makefile:1: warning:  Undefined dependencies [REQUIRES] 
for unit embox.service.bluetooth_debug:: embox.hal.bluetooth_drv
./src/tests/divzero/Makefile:1: warning:  Undefined dependencies [DEPS] for 
unit embox.test.divzero:: embox.hal.test.traps
./src/tests/mmu/Makefile:1: warning:  Undefined dependencies [DEPS] for unit 
embox.test.mmu_contexts:: embox.hal.test.mmu
./src/tests/mmu/Makefile:1: warning:  Undefined dependencies [DEPS] for unit 
embox.test.mmu_dfault:: embox.hal.test.mmu embox.hal.test.traps
./src/tests/mmu/Makefile:1: warning:  Undefined dependencies [DEPS] for unit 
embox.test.mmu_enable:: embox.hal.test.mmu
./src/tests/mmu/Makefile:1: warning:  Undefined dependencies [DEPS] for unit 
embox.test.mmu_page_mark_writeable:: embox.hal.test.mmu embox.hal.test.traps
./src/tests/mmu/Makefile:1: warning:  Undefined dependencies [DEPS] for unit 
embox.test.mmu_pagefault:: embox.hal.test.mmu embox.hal.test.traps
./src/tests/mmu/Makefile:1: warning:  Undefined dependencies [DEPS] for unit 
embox.test.mmu_rw:: embox.hal.test.mmu
./src/tests/mmu/Makefile:1: warning:  Undefined dependencies [DEPS] for unit 
embox.test.mmu_write_protection:: embox.hal.test.mmu embox.hal.test.traps
./src/tests/soft_traps/Makefile:1: warning:  Undefined dependencies [DEPS] for 
unit embox.test.soft_traps:: embox.hal.test.traps
./src/tests/soft_traps/Makefile:1: warning:  Undefined dependencies [DEPS] for 
unit embox.test.soft_traps_data:: embox.hal.test.traps
./src/tests/soft_traps/Makefile:1: warning:  Undefined dependencies [DEPS] for 
unit embox.test.soft_traps_flags:: embox.hal.test.traps
Done.
./conf/mods.conf:1: warning:  Undefined mod embox.driver.vconsole
.
.
gcc compiling of all c-files...
.
.
.
i486-elf-ld -static -nostdlib --cref --relax -T ./build/base/obj/embox.lds 
./src/kernel/nosys.lds -N -g \
        ./build/base/obj/src/kernel/critical/count.o \
        ./build/base/obj/src/kernel/irq.o \
        ./build/base/obj/src/kernel/init.o \
        ./build/base/obj/src/kernel/nosys.o \
        ./build/base/obj/src/kernel/softirq.o \
        ./build/base/obj/src/kernel/thread/core.o \
        ./build/base/obj/src/kernel/thread/sched.o \
        ./build/base/obj/src/kernel/thread/sched_policy/priority_based.o \
        ./build/base/obj/src/kernel/thread/sync/pipe_manager.o \
        ./build/base/obj/src/kernel/thread/sync/mutex.o \
        ./build/base/obj/src/kernel/thread/sync/message.o \
        ./build/base/obj/src/kernel/timer.o \
        ./build/base/obj/src/cmds/cat.o \
        ./build/base/obj/src/cmds/esh/esh.o \
        ./build/base/obj/src/cmds/help.o \
        ./build/base/obj/src/cmds/ls.o \
        ./build/base/obj/src/cmds/lsmod.o \
        ./build/base/obj/src/cmds/lspnp.o \
        ./build/base/obj/src/cmds/man.o \
        ./build/base/obj/src/cmds/mem.o \
        ./build/base/obj/src/cmds/mount.o \
        ./build/base/obj/src/cmds/readelf.o \
        ./build/base/obj/src/cmds/rm.o \
        ./build/base/obj/src/cmds/runelf.o \
        ./build/base/obj/src/cmds/test.o \
        ./build/base/obj/src/cmds/wmem.o \
        ./build/base/obj/src/drivers/ambapp/amba_registry.o \
        ./build/base/obj/src/drivers/ambapp/ambapp.o \
        ./build/base/obj/src/drivers/clock/pit.o \
        ./build/base/obj/src/drivers/interrupt/apic.o \
        ./build/base/obj/src/drivers/keyboard/keyboard.o \
        ./build/base/obj/src/drivers/serial/serial_port.o \
        ./build/base/obj/src/drivers/char/vtbuild.o \
        ./build/base/obj/src/drivers/char/vtparse.o \
        ./build/base/obj/src/drivers/char/vtparse_state.o \
        ./build/base/obj/src/drivers/char/terminal.o \
        ./build/base/obj/src/fs/file.o \
        ./build/base/obj/src/fs/filesystems.o \
        ./build/base/obj/src/fs/vfs.o \
        ./build/base/obj/src/fs/devfs/devfs.o \
        ./build/base/obj/src/fs/fs_driver.o \
        ./build/base/obj/src/fs/node.o \
        ./build/base/obj/src/fs/ramfs/ramfs.o \
        ./build/base/obj/src/fs/rootfs/rootfs.o \
        ./build/base/obj/src/arch/x86/kernel/arch.o \
        ./build/base/obj/src/arch/x86/kernel/context.o \
        ./build/base/obj/src/arch/x86/kernel/context_switch.o \
        ./build/base/obj/src/arch/x86/kernel/idt.o \
        ./build/base/obj/src/arch/x86/kernel/irq_handler.o \
        ./build/base/obj/src/arch/x86/kernel/gdt.o \
        ./build/base/obj/src/arch/x86/kernel/boot.o \
        ./build/base/obj/src/arch/x86/kernel/boot_idt.o \
        ./build/base/obj/src/arch/x86/kernel/gdt_flush.o \
        ./build/base/obj/src/tests/recursion/stack_recursion.o \
        ./build/base/obj/src/tests/setjmp/setjmp.o \
        ./build/base/obj/depsinject.o \
    -L./build/base/lib \
        -lutil \
        -ltest \
        -llinux \
        -lframework \
        -larch \
        -lc \
    -Map build/base/bin/embox.map \
    -o   build/base/bin/embox
./build/base/obj/src/drivers/serial/serial_port.o: In function `irq_handler':
/cygdrive/c/work/EmBox/embox/src/drivers/serial/serial_port.c:194: undefined 
reference to `tty_add_char'
./build/base/obj/src/drivers/serial/serial_port.o: In function `close':
/cygdrive/c/work/EmBox/embox/src/drivers/serial/serial_port.c:209: undefined 
reference to `tty_unregister'
./build/base/obj/src/drivers/serial/serial_port.o: In function `open':
/cygdrive/c/work/EmBox/embox/src/drivers/serial/serial_port.c:203: undefined 
reference to `tty_register'
./build/base/lib/libc.a(readline.o): In function `freeline':
/cygdrive/c/work/EmBox/embox/src/lib/readline/readline.c:21: undefined 
reference to `cur_tty'
/cygdrive/c/work/EmBox/embox/src/lib/readline/readline.c:24: undefined 
reference to `tty_freeline'
./build/base/lib/libc.a(readline.o): In function `readline':
make: *** [all] Error 2
/cygdrive/c/work/EmBox/embox/src/lib/readline/readline.c:13: undefined 
reference to `cur_tty'
/cygdrive/c/work/EmBox/embox/src/lib/readline/readline.c:17: undefined 
reference to `cur_tty'
/cygdrive/c/work/EmBox/embox/src/lib/readline/readline.c:17: undefined 
reference to `tty_readline'
./build/base/lib/libc.a(putchar.o): In function `putchar':
/cygdrive/c/work/EmBox/embox/src/lib/stdio/putchar.c:23: undefined reference to 
`console_putchar'
/cygdrive/c/work/EmBox/embox/src/lib/stdio/putchar.c:21: undefined reference to 
`console_putchar'
./build/base/lib/libc.a(getchar.o): In function `getchar':
/cygdrive/c/work/EmBox/embox/src/lib/stdio/getchar.c:16: undefined reference to 
`console_getchar'
make[2]: *** [build/base/bin/embox] Error 1
make[1]: *** [build_base_target] Error 2

Original issue reported on code.google.com by gerald.h...@aon.at on 14 Jul 2011 at 4:30

GoogleCodeExporter commented 9 years ago

Reproduced

Original comment by Eldar.Abusalimov on 14 Jul 2011 at 4:53

Changed title: Broken x86/console template
Changed state: Accepted
Added labels: Milestone-v0.2.2

GoogleCodeExporter commented 9 years ago

Replacing embox.driver.vconsole with embox.driver.tty_one_console gives the 
following errors:

gcc @build/base/obj/src/drivers/tty/tty_common/tty_action_common.cmd 
src/drivers/tty/tty_common/tty_action_common.c
cc1: warnings being treated as errors
src/drivers/tty/tty_common/tty_action_common.c: In function ‘char_token’:
src/drivers/tty/tty_common/tty_action_common.c:40: error: ‘tmp.params’ is 
used uninitialized in this function
src/drivers/tty/tty_common/tty_action_common.c:40: error: ‘tmp.attrs[1u]’ 
is used uninitialized in this function
src/drivers/tty/tty_common/tty_action_common.c:40: error: ‘tmp.attrs[0u]’ 
is used uninitialized in this function
src/drivers/tty/tty_common/tty_action_common.c: In function 
‘tty_write_space’:
src/drivers/tty/tty_common/tty_action_common.c:40: error: ‘tmp$params’ may 
be used uninitialized in this function
src/drivers/tty/tty_common/tty_action_common.c:34: note: ‘tmp$params’ was 
declared here
src/drivers/tty/tty_common/tty_action_common.c:40: error: ‘tmp$attrs$1’ may 
be used uninitialized in this function
src/drivers/tty/tty_common/tty_action_common.c:34: note: ‘tmp$attrs$1’ was 
declared here
src/drivers/tty/tty_common/tty_action_common.c:40: error: ‘tmp$attrs$0’ may 
be used uninitialized in this function
src/drivers/tty/tty_common/tty_action_common.c:34: note: ‘tmp$attrs$0’ was 
declared here
make[2]: *** [build/base/obj/src/drivers/tty/tty_common/tty_action_common.o] 
Error 1
make[1]: *** [build_base_target] Error 2
make: *** [all] Error 2

Original comment by Eldar.Abusalimov on 14 Jul 2011 at 5:05

Changed title: Broken x86/console template, dirty tty code
Added labels: Component-Logic

GoogleCodeExporter commented 9 years ago

tty code will be rewriten, but we'll use different issues for it.
Console template was correct.
We also will clean some templates

Original comment by Anton.Bo...@gmail.com on 22 Nov 2011 at 8:29

GoogleCodeExporter commented 9 years ago

Original comment by Anton.Bo...@gmail.com on 22 Nov 2011 at 8:30

Changed state: Fixed

SmallLonlyWolf / embox

Broken x86/console template, dirty tty code #318