search

Smanar / Domoticz-deCONZ

deCONZ plugin for Domoticz (Zigbee application)
GNU General Public License v3.0
36 stars 27 forks source link

Add compatibility with Xiaomi Cube T1 & Pro T1 #153

Closed Sumd84 closed 1 year ago

Sumd84 commented 1 year ago

The new Aqara Cube T1 & Pro T1 has a model id "lumi.remote.cagl01/cagl02". Those have been recently added in deconz-rest-plugin https://github.com/dresden-elektronik/deconz-rest-plugin/pull/5838

I kept XCube_R/XCube_C for the main branch.

But for my personal needs, I defined specific XCubeProT1_R/XCubeProT1_C (also the conversion functions in function.py). As I prefer to keep the main branch clean, I refrain from pulling those modifications.

Smanar commented 1 year ago

As I prefer to keep the main branch clean, I refrain from pulling those modifications.

Yep exactly ^^, else it will trigger plugin update on domoticz user, but you can make a PR on the beta branch, this one is just for that.

also the conversion functions in function.py

The code is working as it, or need to add convertion fonction too in fonction.py ?

Sumd84 commented 1 year ago

The code is working as it, or need to add convertion fonction too in fonction.py ?

Let me just double-check that only this commit works fine with my Domoticz (without other modifications).

Yep exactly ^^, else it will trigger plugin update on domoticz user, but you can make a PR on the beta branch, this one is just for that.

Ok. Thanks for the tip 👍

Sumd84 commented 1 year ago

Just checked on Domoticz and everything works fine.

Smanar commented 1 year ago

Nice, thx, but can you make the PR on the beta branch ?

Sumd84 commented 1 year ago

Change the PR to beta but as I am quite a noob with github maybe I didn't made the right thing xD. Sorry if I messed up something.

Smanar commented 1 year ago

I can't, you need to cancel this one and remake a new PR from your fork (like you have done before) but to the branch "beta" instead of "master"