SmartAPI / smartAPI

Intelligent APIs for a more connected web: https://smart-api.info
MIT License
21 stars 16 forks source link

Uptime-checking failing for PharmGKB registration #186

Open colleenXu opened 1 year ago

colleenXu commented 1 year ago

(Copied from internal Slack thread)

This isn't urgent.

I'm not sure why uptime-checking is failing for some endpoints (SmartAPI link), since they successfully run when I "try an example" using the example parameter values for those endpoints. I wondered if it had to do with the rate-limiting of this API (its documentation says it only accepts 2 requests / sec).

Marco noted that the failing endpoints have info like this: :red_circle: /data/pathway: (400) {"status":"fail","data":{"errors":[{"message":"Missing criteria."}]}}

However, for those endpoints, no required parameters are missing an example value. For example, the /data/variantAnnotation endpoint has an example provided for every parameter....so these error messages are unexpected and confusing

colleenXu commented 1 year ago

Came up while addressing this issue https://github.com/biothings/BioThings_Explorer_TRAPI/issues/556