search

SmartBear / git-en-boite

Web service facade for interacting with git repos on various providers - GitHub/BitBucket/GitLab etc.
MIT License
18 stars 7 forks source link

Show refs for repos with tags (or other "unexpected" refs) #222

Open mattwynne opened 4 years ago

mattwynne commented 4 years ago

If the code in handleGetRefs throws any kind of error, we just return an empty Refs() object.

The error swallowing was presumably for dealing with calls to show-refin empty repos, but it's also swallowing errors parsing refs.

Need to change this so the try/catch block is only around the call to show-ref and not the parsing bit, so that parsing errors are still thrown.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🙏.

mattwynne commented 4 years ago

Not stale, this is important!

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🙏.

mattwynne commented 3 years ago

We've got to fix this. It won't take long and it will exclude lots of user's repos.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🙏.

mattwynne commented 3 years ago

I've cleaned up this code and it seems to be working now. Closing.