Closed rbren closed 9 years ago
olensmar
commented
9 years ago Thank you!
Could you merge this into the version-2.1 branch instead - I need to merge that back into master (or I can do that first if you prefer...)
Does this mandate a new release (2.1.2)?
/Ole
rbren
commented
9 years ago Just created a new pull request for the 2.1.1 branch. I'd love to test the changes, but I'm having some trouble with Maven deps:
Failed to execute goal on project soapui-swagger-plugin: Could not resolve dependencies for project com.smartbear:soapui-swagger-plugin:jar:2.1.1: The following artifacts could not be resolved: com.smartbear:ready-api-soapui-pro:jar:1.2.0, io.swagger:swagger-parser:jar:1.0.6-SNAPSHOT: Failure to find com.smartbear:ready-api-soapui-pro:jar:1.2.0 in http://www.soapui.org/repository/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of soapUI Repository has elapsed or updates are forced -> [Help 1]
I can fix most of them by changing versions to what's available at http://www.soapui.org/repository/maven2, but can't find anything for swagger-parser.jar.
I'm not waiting on a new release, I was just copying some of your code into my own plugin (https://github.com/lucybot/soapui-lucybot-plugin). I'll actually be at SmartBear for your talk on Thursday if you want to take a look!
-Bobby
Bobby Brennan bobby.brennan@gmail.com
On Tue, May 5, 2015 at 12:44 PM, Ole Lensmar notifications@github.com wrote:
Thank you!
Could you merge this into the version-2.1 branch instead - I need to merge that back into master (or I can do that first if you prefer...)
Does this mandate a new release (2.1.2)?
/Ole
— Reply to this email directly or view it on GitHub https://github.com/olensmar/soapui-swagger-plugin/pull/7#issuecomment-99136050 .
olensmar
commented
9 years ago Awesome - I'll definitely want to take a look - looking forward to it :-)
Regarding the dependencies - the swagger one is internal, was required for 2.1.1 - I'll have to check when 1.0.6 is going out. The others you can fix as you suggested.
See you!
/Ole
From: Bobby Brennan notifications@github.com<mailto:notifications@github.com> Reply-To: olensmar/soapui-swagger-plugin reply@reply.github.com<mailto:reply@reply.github.com> Date: Tuesday 5 May 2015 13:39 To: olensmar/soapui-swagger-plugin soapui-swagger-plugin@noreply.github.com<mailto:soapui-swagger-plugin@noreply.github.com> Cc: Ole Lensmar ole.lensmar@smartbear.com<mailto:ole.lensmar@smartbear.com> Subject: Re: [soapui-swagger-plugin] Fix bug in operationHasParameter (#7)
Just created a new pull request for the 2.1.1 branch. I'd love to test the changes, but I'm having some trouble with Maven deps:
Failed to execute goal on project soapui-swagger-plugin: Could not resolve dependencies for project com.smartbear:soapui-swagger-plugin:jar:2.1.1: The following artifacts could not be resolved: com.smartbear:ready-api-soapui-pro:jar:1.2.0, io.swagger:swagger-parser:jar:1.0.6-SNAPSHOT: Failure to find com.smartbear:ready-api-soapui-pro:jar:1.2.0 in http://www.soapui.org/repository/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of soapUI Repository has elapsed or updates are forced -> [Help 1]
I can fix most of them by changing versions to what's available at http://www.soapui.org/repository/maven2, but can't find anything for swagger-parser.jar.
I'm not waiting on a new release, I was just copying some of your code into my own plugin (https://github.com/lucybot/soapui-lucybot-plugin). I'll actually be at SmartBear for your talk on Thursday if you want to take a look!
-Bobby
Bobby Brennan bobby.brennan@gmail.commailto:bobby.brennan@gmail.com
On Tue, May 5, 2015 at 12:44 PM, Ole Lensmar notifications@github.com<mailto:notifications@github.com> wrote:
Thank you!
Could you merge this into the version-2.1 branch instead - I need to merge that back into master (or I can do that first if you prefer...)
Does this mandate a new release (2.1.2)?
/Ole
Reply to this email directly or view it on GitHub https://github.com/olensmar/soapui-swagger-plugin/pull/7#issuecomment-99136050 .
Reply to this email directly or view it on GitHubhttps://github.com/olensmar/soapui-swagger-plugin/pull/7#issuecomment-99154928.
FYI this change is untested.
I'm new to Groovy, but it seems you can't return from inside the each{} block, which means operationHasParameter always returns false currently.