POM updates for tar, Tomcat and log4j

[bencomp]

I could not build a tar file before, because my Unix group number was too high. I followed the Apache Maven Assembly guidance to solve this.

I also moved the log4j.properties files and updated the POMs so that it is correctly copied to the target configuration directory and correctly referenced from there.

Finally I commented out some POM configuration elements that were not allowed and it seemed not to have any influence on the build.

If you have any comments, I'm happy to discuss them.

[SimonBin]

have to admit I don't understand much of the accumulated cruft in the pom. with that said, why do you want to move the log4j.properties?

[bencomp]

Well, during packaging this part of the appassembler configuration:

<configurationSourceDirectory>src/main/conf</configurationSourceDirectory>
<!-- Set the target configuration directory -->
<configurationDirectory>etc</configurationDirectory>
<!-- Copy the contents from "/src/main/conf" to the target -->
<copyConfigurationDirectory>true</copyConfigurationDirectory>
<!-- Include the target configuration directory in the classpath -->
<includeConfigurationDirectoryInClasspath>true</includeConfigurationDirectoryInClasspath>
<extraJvmArguments>
    -Xms256m -Xmx2g -Dlog4j.configuration=file:@BASEDIR@/etc/log4j.properties
</extraJvmArguments>

makes that only the .gitkeep file that is in src/main/conf is copied to the etc directory (because log4j.properties is in src/main/resources) and that the startup scripts look in etc for the log4j.properties file. When I build and run e.g. the cli program, I get a warning that there is no log4j configuration. It does not appear to affect the build or test process, making me think that there are no further references to the files.

In two places I updated the reference to the former location (even though those references were enclosed in typos meaning that they couldn't have been used).

Does this help explain?

[SimonBin]

been awhile, thanks again