SmartDataAnalytics / OpenResearch

Public issue system for OPENRESEARCH/ConfIDent
8 stars 3 forks source link

Place "Virtual" as City is displayed as being in Bologna #219

Closed hauschke closed 3 years ago

hauschke commented 3 years ago

grafik

Example: https://confident.dbis.rwth-aachen.de/or/index.php?title=FABRICATE_2020

WolfgangFahl commented 3 years ago

Duplicate of #209

WolfgangFahl commented 3 years ago

"Online" is fed into #geocode of the https://www.mediawiki.org/wiki/Extension:Maps which in turn calls the configured geocoding service. The result is directly put into https://confident.dbis.rwth-aachen.de/or/index.php?title=Property:Has_coordinates without checking whether the result is o.k. The base problem is exactly the one outlined in the Migration Plan summary.

Worse - the design of the approach is flawed since the geocoding is done redudantly for each event instead of getting the geocode result for a venue once and reusing it for all events happening at that venue. For each and every template change currently some 10.000 API geocoding calls are fired and we end up our quota with the service being exceeded.