SmartFinn / eve-ng-integration

integrates EVE-NG (aka UNetLab) with Linux desktop
http://git.io/eve-ng-integration
MIT License
322 stars 117 forks source link

Fixed Popen erroneous call and added st #41

Open noahboegli opened 3 years ago

noahboegli commented 3 years ago

Hi!

I've just started using eve-ng for a network class at uni, and I've run into an issue with the client integration. Basically, the telnet opening would cause the program to exit with a code 1.

I've been able to pin-point that down to the Popen call, it seems like it expects every argument to be an item of the list instead of having one with spaces (see: https://docs.python.org/3/library/subprocess.html#popen-constructor). I am not a Python specialist, but simply splitting the command list if its length equals to one fixed it for me.

I've also added st in the term finder since it was not here.

Please tell me if I have accidentally broken something by fixing the issue that way (I've taken an extra security step by splitting only if the length equals 1).

Kind Regards, Noah