SmartGrid-ETHIndia / Smart-grid

https://smart-ethindia.vercel.app/
MIT License
22 stars 25 forks source link

Improve Header UI and Metamask address slice. #25

Closed ENZOMOTIVE closed 1 month ago

ENZOMOTIVE commented 1 month ago

Screenshot 2024-05-09 231621 Hey, @Mayank2808sharma I would like to improve the header part to make it visually appealing and also make the meta mask address display sliced so that it does not showcase the whole address, as this may lead to issues in the future. So please assign me the task.

Mayank2808sharma commented 1 month ago

@ENZOMOTIVE Go ahead, I have assigned the issue to you.

ENZOMOTIVE commented 1 month ago

image @Mayank2808sharma I have made the changes and created a pull request.

ENZOMOTIVE commented 1 month ago

@Mayank2808sharma i have pulled the request to the master branch but deployement failed is showing. the code is working perfectly on my machine

ENZOMOTIVE commented 1 month ago

I did it but it fails I only made some typescript and css changes and nothings seems an error to me. But the deployment failed. on which branch do I need to ull because I pulled on the master.

On Thu, May 9, 2024 at 11:37 PM Mayank Sharma @.***> wrote:

@ENZOMOTIVE https://github.com/ENZOMOTIVE Go ahead, I have assigned the issue to you.

— Reply to this email directly, view it on GitHub https://github.com/SmartGrid-ETHIndia/Smart-grid/issues/25#issuecomment-2103169557, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVW2MRM7YFPHOLKSFG2WHULZBO3PBAVCNFSM6AAAAABHPHME2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBTGE3DSNJVG4 . You are receiving this because you were mentioned.Message ID: @.***>

Mayank2808sharma commented 1 month ago

After making some changes, make sure to run npm run build to check if the build is failing or not. If it fails, there might be an issue with your code.

ENZOMOTIVE commented 1 month ago

@Mayank2808sharma Succesfully merged the pull request thank you. So, now do I need to do something additional like how will I get points that I made the contribution.