search

SmartGridready / SGrJava

SmartGridready communication handler in Java
0 stars 0 forks source link

Modbus gateway registry #62

Closed mkrebs81 closed 1 week ago

mkrebs81 commented 1 month ago
mkrebs81 commented 1 week ago

After refactoring several times and conducting some tests with multiple serial devices, I think the implementation is ready to be integrated. The "old" methods should still work, but you need to manage the transport yourself.

ergo-furrer commented 1 week ago

@mkrebs81 Looks good. I think we should make a follow-up issue to remove the the legacy functionalites. We also could consider making the GatewayRegistry a singleton to avoid having two instances of the registry that could possibly connect both to the same COM port.

mkrebs81 commented 1 week ago

@ergo-furrer shall I merge this as well, or should we wait for a few more test results?

ergo-furrer commented 1 week ago

@ergo-furrer shall I merge this as well, or should we wait for a few more test results?

I think we can merge unless you prefer to wait for more test results (we can always make a fix if something turns out to be buggy). I also added the removal of legacy stuff to my TODO list for later.

mkrebs81 commented 1 week ago

OK, great. I will merge it today, as it will make my development easier. When something comes to my mind regarding the refactoring, I will edit the description of the issue or add a comment.