Improve generic API with device builder and connect/disconnect methods

SmartGridready / SGrJava

SmartGridready communication handler in Java

0 stars 0 forks source link

Improve generic API with device builder and connect/disconnect methods #66

Closed mkrebs81 closed 3 months ago

mkrebs81 commented 3 months ago

This changes how the generic device API works...

added generic device builder, like in python implementation
Modbus transports are created inside the device builder, via a factory
added connect and disconnect methods to generic device API. these methods actually connect or disconnect the underlying transports. just creating the device instance is not enough.

devices can still be created using the old method, but calling connect/disconnect is mandatory.

ergo-furrer commented 3 months ago

@mkrebs81 I wrote some unit-tests for the SGrDeviceBuilder. The SGrDeviceBuilder works fine 😄 (if you change to 'eid.xml'). I can commit the tests on a separate branch or on this branch. If I commit here Arnd has to approve. Shall I commit on a separate branch?

mkrebs81 commented 3 months ago

thanks for your feedback. you can commit on a separate branch, and I will check it out and merge it from there.