Translatable "share" string should not be shared between header and a button

[Aga-C]

Hi,

I've noticed that in the app you're reusing the translatable string "share" between the header of the dialog and an action button (check screenshot below). It sounds good in English, but it's not the case in other languages.

In this case, the wrong text in the header "Udostępnij [something]?" could be translated back to English as "Would you share [something]?". Properly it should be "Udostępnić [something]?" while action button should still be "Udostępnij".

In my opinion the best way to approach this would be to create a separate string with a formatter placeholder, something like "Share %s?". This will be also more proof for other languages that can use other order of words.

Thanks!

[sunilpaulmathew]

@Aga-C Fully agree with your comment. I'll look for a solution as you suggested, although it will make headaches for translators. Thank you.

[Aga-C]

@sunilpaulmathew I've seen your commit and I think you've changed other text than I mentioned 😅 I meant to separate the header title to not share the same string with a button.

However, the change is good, because now that message can also be better translated 👍

Thanks!

[sunilpaulmathew]

@Aga-C Infact, I forgot to update the title. I'm planning to simply show the exported app name there, so that it will be like the attached image. Thanks again.

[Aga-C]

Hi. Can you add the new string export_apk_summary to POEditor?

[sunilpaulmathew]

Hi. Can you add the new string export_apk_summary to POEditor?

Sure, will be done this evening or tomorrow. No access to computer now. Thank You

[sunilpaulmathew]

Hi. Can you add the new string export_apk_summary to POEditor?

It is done! Also, closing this issue as well. Feel free to reopen it, if needed. Thank You!