search

SmartPack / PackageManager

Source code of Package Manager, an Application to Manage your Apps.
https://smartpack.github.io/PackageManager/
GNU General Public License v3.0
448 stars 59 forks source link

Settings visual improvements #54

Closed Aga-C closed 3 years ago

Aga-C commented 3 years ago

Hi,

In the test build, the sections names should look a bit different from the settings. I think that now with section names, it would look better if you'd:

In the screenshot below, I've marked which lines I'd remove and what should be written with a smaller font. image

Also, there is a bug: an icon for Documentation is invisible in the light theme. image

sunilpaulmathew commented 3 years ago

@Aga-C That is a great suggestion I really like to work on.

Valdnet commented 3 years ago

@Aga-C Very good suggestions 👍.

@sunilpaulmathew I would also fix the icon for "Translation" because its color is inappropriate for a dark theme. It stands out too much. I would stick to the color of the themes. And for a light theme, the icon is half obscured by a black background.

sunilpaulmathew commented 3 years ago

@Aga-C Very good suggestions 👍.

@sunilpaulmathew I would also fix the icon for "Translation" because its color is inappropriate for a dark theme. It stands out too much. I would stick to the color of the themes. And for a light theme, the icon is half obscured by a black background.

In fact, I leave it as such with an aim to get more attention from users. Also, it need some work to make it black/white as the respective drawable for that specific icon is different (got from an external website while others are from android studio).

Valdnet commented 3 years ago

In fact, I leave it as such with an aim to get more attention from users.

But that doesn't fit in with the whole thing.

The icon needs to be processed anyway, because for a light theme it is obscured by a black background.

I suggest replacing this icon with an icon from the icon gallery that will match the given option. After all, it doesn't have to be an icon for the translation page. I would even suggest changing it 😉.

sunilpaulmathew commented 3 years ago

After all, it doesn't have to be an icon for the translation page.

Of course, but they are so kind to opensource community. Provided free translation for almost all of my application. Anyway, I'll look for an alternate solution.

Valdnet commented 3 years ago

It is certainly enough that you mention them in the text string 😉.

sunilpaulmathew commented 3 years ago

I think this is good enough for now? Screenshot_1631648263

Aga-C commented 3 years ago

Looks good 👍 Maybe there could be just a bit larger margin between the app title and the first section name.

sunilpaulmathew commented 3 years ago

Looks good 👍 Maybe there could be just a bit larger margin between the app title and the first section name.

Done. Btw, any comments on this? Probably a better description. Screenshot_1631651328

Aga-C commented 3 years ago

For me, it's ok.

@Valdnet What do you think?

sunilpaulmathew commented 3 years ago

For me, it's ok.

@Valdnet What do you think?

@Valdnet Btw, this one too... Screenshot_1631652863

sunilpaulmathew commented 3 years ago

@Valdnet @Aga-C Here is a test build when you have time. I guess almost everything is addressed (at least in an initial form). I shall upload the strings into POEditor after receiving your initial comments. Btw, I should add a new section in credits for you two 😉

Aga-C commented 3 years ago

Now, I've also noticed that the section name is "Others" - shouldn't it be "Other"? "Others" is referring to people. Besides it, everything looks ok (new functions and visual changes).

sunilpaulmathew commented 3 years ago

Others" is referr

Thanks again & sorry for my ignorance again :)

Valdnet commented 3 years ago

@sunilpaulmathew It looks so much better now 👍. I would only change the line thickness under the settings titles. It's a bit too fat. It's too conspicuous. Set the thickness to the same as it is for the line, e.g. in the "All" window 😉.

Valdnet commented 3 years ago

Remember to reduce the line thickness to 1px in the application menu 😉.

sunilpaulmathew commented 3 years ago

@Valdnet If I forgot after the vacation, please please remind me again :)

Valdnet commented 3 years ago

Remember to reduce the line thickness to 1px in the application menu

@sunilpaulmathew And how, are you working on this issue?

BTW: If you had a moment, please help me translate this Simply Translate Mobile application into your mother tongue and into the languages you know. Details for translation. Thanks.

sunilpaulmathew commented 3 years ago

@sunilpaulmathew And how, are you working on this issue?

Sorry for not updating. I was playing with another little project (now planning to jump here).

BTW: If you had a moment, please help me translate this Simply Translate Mobile application into your mother tongue and into the languages you know. Details for translation. Thanks.

Of course, if it is helpful, I'll be happy to try (never did it seriously before; so, a little bit worried) translating to one of the most complicated languages on the earth: Malayalam - my mother tongue. I'll hopefully have a lot of free time tomorrow afternoon & on weekend.